shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

pvscan: remove warning about excluded root dev

Browse Source 
This was trying to warn about a misconfig where the root PV
was excluded by the devices file, but it wasn't covering all
cases.  Also, it's not very useful because the root LV is
usually activated directly in the initrd.
This commit is contained in:
David Teigland 2023-02-15 10:21:13 -06:00
parent bd05318ba2
commit 08265641f3
1 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tools/pvscan.c
View File

@ -1355,29 +1355,6 @@ static int _pvscan_cache_all(struct cmd_context *cmd, int argc, char **argv,
return 1;
}
/*
* If /dev/sda* of /dev/vda* is excluded by the devices file
* it's usually a misconfiguration that prevents proper booting,
* so make it a special case to give extra info to help debugging.
*/
static void _warn_excluded_root(struct cmd_context *cmd, struct device *dev)
{
struct dev_use *du;
const char *cur_idname;
if (!(du = get_du_for_devname(cmd, dev_name(dev)))) {
log_warn("WARNING: no autoactivation for %s: not found in system.devices.", dev_name(dev));
return;
}
cur_idname = device_id_system_read(cmd, dev, du->idtype);
log_warn("WARNING: no autoactivation for %s: system.devices %s current %s.",
dev_name(dev), du->idname, cur_idname ?: "missing device id");
free((void*) cur_idname);
}
static int _pvscan_cache_args(struct cmd_context *cmd, int argc, char **argv,
struct dm_list *complete_vgnames)
{
@ -1523,12 +1500,6 @@ static int _pvscan_cache_args(struct cmd_context *cmd, int argc, char **argv,
log_print_pvscan(cmd, "%s excluded: %s.",
dev_name(devl->dev), dev_filtered_reason(devl->dev));
dm_list_del(&devl->list);
/* Special case warning when probable root dev is missing from system.devices */
if ((devl->dev->filtered_flags & DEV_FILTERED_DEVICES_FILE) &&
(!strncmp(dev_name(devl->dev), "/dev/sda", 8) ||
!strncmp(dev_name(devl->dev), "/dev/vda", 8)))
_warn_excluded_root(cmd, devl->dev);
}
}