shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-21 22:04:19 +03:00
Code Releases Activity

dmeventd: check for list size within lock

Browse Source 
Move check for _thread_registry list size behind mutex.
Use alloca() instead of buffer[count] (they are the same anyway)
This commit is contained in:
Zdenek Kabelac 2014-04-18 13:29:38 +02:00
parent 0e05e1cf6c
commit 08e7de986c
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
daemons/dmeventd/dmeventd.c
View File

@ -464,20 +464,17 @@ static int _get_status(struct message_data *message_data)
{
struct dm_event_daemon_message *msg = message_data->msg;
struct thread_status *thread;
int i, j;
int ret = -1;
int count = dm_list_size(&_thread_registry);
int i = 0, j;
int ret = -ENOMEM;
int count;
int size = 0, current;
char *buffers[count];
size_t len;
char **buffers;
char *message;
dm_free(msg->data);
for (i = 0; i < count; ++i)
buffers[i] = NULL;
i = 0;
_lock_mutex();
count = dm_list_size(&_thread_registry);
buffers = alloca(sizeof(char*) * count);
dm_list_iterate_items(thread, &_thread_registry) {
if ((current = dm_asprintf(buffers + i, "0:%d %s %s %u %" PRIu32 ";",
i, thread->dso_data->dso_name,