From 0b0c2117afa3f2075fbaa21757416d484ab4c7d9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <jim@meyering.net>
Date: Mon, 24 Sep 2007 19:19:18 +0000
Subject: [PATCH] Avoid over-quoting in shell scripts.

Do not use "..." around the RHS of VAR= assignment,
nor on the argument of "case ... in ...".


Author: Jim Meyering <jim@meyering.net>
---
 test/t-lvcreate-pvtags.sh          | 2 +-
 test/t-lvcreate-usage.sh           | 6 +++---
 test/t-lvextend-percent-extents.sh | 6 +++---
 test/t-pv-range-overflow.sh        | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/t-lvcreate-pvtags.sh b/test/t-lvcreate-pvtags.sh
index 223c91689..b230e795d 100755
--- a/test/t-lvcreate-pvtags.sh
+++ b/test/t-lvcreate-pvtags.sh
@@ -35,7 +35,7 @@ pvsize=$((200 * 1024 * 2))
 
 test_expect_success \
   'set up temp file and loopback device' \
-  'lofile="$(pwd)/lofile" && lodev=$(loop_setup_ "$lofile")'
+  'lofile=$(pwd)/lofile && lodev=$(loop_setup_ "$lofile")'
 
 offset=0
 pvs=
diff --git a/test/t-lvcreate-usage.sh b/test/t-lvcreate-usage.sh
index f59ad4c46..cd488c51e 100755
--- a/test/t-lvcreate-usage.sh
+++ b/test/t-lvcreate-usage.sh
@@ -28,8 +28,8 @@ cleanup_()
 
 test_expect_success \
   'set up temp files, loopback devices, PVs, and a VG' \
-  'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") &&
-   f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") &&
+  'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
+   f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
    pvcreate $d1 $d2      &&
    vg=$(this_test_)-test-vg-$$  &&
    vgcreate $vg $d1 $d2'
@@ -71,7 +71,7 @@ test_expect_success \
   'lvcreate rejects an invalid stripe size' \
   'lvcreate -L 64M -n $lv -i2 --stripesize 3 $vg 2>err; test $? = 3 &&
    grep "^  Invalid stripe size 3\.00 KB\$" err &&
-   case "$(lvdisplay $vg)" in "") true ;; *) false ;; esac'
+   case $(lvdisplay $vg) in "") true ;; *) false ;; esac'
 
 test_done
 # Local Variables:
diff --git a/test/t-lvextend-percent-extents.sh b/test/t-lvextend-percent-extents.sh
index 773ca7fa4..6c294acfc 100755
--- a/test/t-lvextend-percent-extents.sh
+++ b/test/t-lvextend-percent-extents.sh
@@ -28,8 +28,8 @@ cleanup_()
 
 test_expect_success \
   'set up temp files, loopback devices, PVs, and a VG' \
-  'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") &&
-   f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") &&
+  'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
+   f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
    pvcreate $d1 $d2      &&
    vg=$(this_test_)-test-vg-$$  &&
    vgcreate $vg $d1 $d2 &&
@@ -65,7 +65,7 @@ test_expect_success \
   check_pv_size_ $d2 "0"'
 
 # Exercise the range overlap code.  Allocate every 2 extents.
-# 
+#
 #      Physical Extents
 #           1         2
 #012345678901234567890123
diff --git a/test/t-pv-range-overflow.sh b/test/t-pv-range-overflow.sh
index 20ebefdcf..d08d63604 100755
--- a/test/t-pv-range-overflow.sh
+++ b/test/t-pv-range-overflow.sh
@@ -28,8 +28,8 @@ cleanup_()
 
 test_expect_success \
   'set up temp files, loopback devices, PVs, VG, LV' \
-  'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") &&
-   f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") &&
+  'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
+   f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
    pvcreate $d1 $d2              &&
    vg=pvmove-demo-vg-$$          &&
    vgcreate "$vg" $d1 $d2        &&