mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
Disallow toggling the cluster attribute of a volume group if there
are active mirrors or snapshots. We don't have the mechanisms in place to change the device-mapper tables for those targets that have behavioral differences between cluster and single machine instances. Allowing users to change the attribute but not changing the target's behavior can lead to data corruption. The following bugs are fixed/avoided by this patch: 235123 - vgchange -c [ny] do not change target types when necessary 289331 - RFE: switching from cluster domain to local domain needs to deactivate volume somehow 289541 - when changing from local to cluster, volumes can not appear to be deactivated
This commit is contained in:
parent
578c4098e6
commit
0d272a6964
@ -1,5 +1,6 @@
|
||||
Version 2.02.65 -
|
||||
=================================
|
||||
Disallow cluster attr toggling if there are active mirrors or snapshots.
|
||||
Use /bin/bash for scripts with bashisms.
|
||||
Skip internal lvm devices in scan if ignore suspended devices is requested.
|
||||
Do not merge old device cache after we run full scan. (2.02.56)
|
||||
|
@ -691,6 +691,7 @@ int lv_remove_mirrors(struct cmd_context *cmd, struct logical_volume *lv,
|
||||
|
||||
int is_temporary_mirror_layer(const struct logical_volume *lv);
|
||||
struct logical_volume * find_temporary_mirror(const struct logical_volume *lv);
|
||||
int lv_is_mirrored(const struct logical_volume *lv);
|
||||
uint32_t lv_mirror_count(const struct logical_volume *lv);
|
||||
uint32_t adjusted_mirror_region_size(uint32_t extent_size, uint32_t extents,
|
||||
uint32_t region_size);
|
||||
|
@ -1208,8 +1208,19 @@ int vg_set_alloc_policy(struct volume_group *vg, alloc_policy_t alloc)
|
||||
int vg_set_clustered(struct volume_group *vg, int clustered)
|
||||
{
|
||||
struct lv_list *lvl;
|
||||
if (clustered) {
|
||||
dm_list_iterate_items(lvl, &vg->lvs) {
|
||||
|
||||
/*
|
||||
* We do not currently support switching the cluster attribute
|
||||
* on active mirrors or snapshots.
|
||||
*/
|
||||
dm_list_iterate_items(lvl, &vg->lvs) {
|
||||
if (lv_is_mirrored(lvl->lv) && lv_is_active(lvl->lv)) {
|
||||
log_error("Mirror logical volumes must be inactive "
|
||||
"when changing the cluster attribute.");
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (clustered) {
|
||||
if (lv_is_origin(lvl->lv) || lv_is_cow(lvl->lv)) {
|
||||
log_error("Volume group %s contains snapshots "
|
||||
"that are not yet supported.",
|
||||
@ -1217,6 +1228,13 @@ int vg_set_clustered(struct volume_group *vg, int clustered)
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
if ((lv_is_origin(lvl->lv) || lv_is_cow(lvl->lv)) &&
|
||||
lv_is_active(lvl->lv)) {
|
||||
log_error("Snapshot logical volumes must be inactive "
|
||||
"when changing the cluster attribute.");
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
if (clustered)
|
||||
|
@ -72,6 +72,14 @@ struct logical_volume *find_temporary_mirror(const struct logical_volume *lv)
|
||||
return NULL;
|
||||
}
|
||||
|
||||
int lv_is_mirrored(const struct logical_volume *lv)
|
||||
{
|
||||
if (lv->status & MIRRORED)
|
||||
return 1;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* Returns the number of mirrors of the LV
|
||||
*/
|
||||
|
Loading…
Reference in New Issue
Block a user