shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

raid: skip frozen raid devices

Browse Source 
Some kernel version suffer from bad state transition where a device
steps into 'frozen' mode. Any application that tries to read such
raid gets unfortunatelly bloked.

As some sort of protection try to skip such raid device from being
scanned to minimize chances to block lvm2 command on such scan.

When such device is found, warning gets printed.
This commit is contained in:
Zdenek Kabelac 2018-03-08 13:18:39 +01:00
parent a8a579b154
commit 0edd89fadc
2 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.178 - Version 2.02.178 -
===================================== =====================================
Skip frozen raid devices from scanning.
Activate RAID SubLVs on read_only_volume_list readwrite Activate RAID SubLVs on read_only_volume_list readwrite
Offer convenience type raid5_n converting to raid10 Offer convenience type raid5_n converting to raid10
Automatically avoid reading invalid snapshots during device scan. Automatically avoid reading invalid snapshots during device scan.

33
lib/activate/dev_manager.c
View File

@ -531,15 +531,38 @@ static int _ignore_invalid_snapshot(const char *params)
{ {
struct dm_status_snapshot *s; struct dm_status_snapshot *s;
struct dm_pool *mem; struct dm_pool *mem;
int r; int r = 0;
if (!(mem = dm_pool_create("invalid snapshots", 128))) if (!(mem = dm_pool_create("invalid snapshots", 128)))
return_0; return_0;
if (!dm_get_status_snapshot(mem, params, &s)) if (!dm_get_status_snapshot(mem, params, &s))
stack;
else
r = s->invalid;
dm_pool_destroy(mem);
return r;
}
static int _ignore_frozen_raid(struct device *dev, const char *params)
{
struct dm_status_raid *s;
struct dm_pool *mem;
int r = 0;
if (!(mem = dm_pool_create("frozen raid", 128)))
return_0; return_0;
r = s->invalid; if (!dm_get_status_raid(mem, params, &s))
stack;
else if (s->sync_action && !strcmp(s->sync_action, "frozen")) {
log_warn("WARNING: %s frozen raid device (%d:%d) needs inspection.",
dev_name(dev), (int)MAJOR(dev->dev), (int)MINOR(dev->dev));
r = 1;
}
dm_pool_destroy(mem); dm_pool_destroy(mem);
return r; return r;
@ -669,6 +692,12 @@ int device_is_usable(struct device *dev, struct dev_usable_check_params check)
goto out; goto out;
} }
if (!strncmp(target_type, TARGET_NAME_RAID, 4) && _ignore_frozen_raid(dev, params)) {
log_debug_activation("%s: Frozen %s device %s not usable.",
dev_name(dev), target_type, name);
goto out;
}
/* TODO: extend check struct ? */ /* TODO: extend check struct ? */
if (!strcmp(target_type, TARGET_NAME_THIN) && if (!strcmp(target_type, TARGET_NAME_THIN) &&
!_ignore_unusable_thins(dev)) { !_ignore_unusable_thins(dev)) {