shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-28 03:27:58 +03:00
Code Releases Activity

Allow manipulation with precommited metadata even when a PV is missing.

Browse Source 
The new recovery code first tries to repair LV and then removes failed PV
from VG. It means that during operation there can be VG with PV missing,
and vg_read code handles it like not consistent VG.

We already allows returning "inconsistent" commited metadata,
for mirror repair we need this for precommited too.
(The suspend call prepares precommited metadata to inactive table on
other cluster nodes.)

"Inconsistent" here means - correct metadata, just with some metadata areas
not found (obviously on missing or failed PVs).
This commit is contained in:
Milan Broz 2009-12-09 19:29:04 +00:00
parent 27132718d4
commit 0fa0e6addf
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.57 -
====================================
Allow use precommited metadata when a PV is missing.
Add memlock information to do_lock_lv debug output.
Never use distributed lock for LV in non-clustered VG.
Allow implicit lock conversion in pre/post callbacks on local node.

13
lib/metadata/metadata.c
View File

@ -2481,6 +2481,7 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
int inconsistent = 0;
int inconsistent_vgid = 0;
int inconsistent_pvs = 0;
int inconsistent_seqno = 0;
unsigned use_precommitted = precommitted;
unsigned saved_handles_missing_pvs = cmd->handles_missing_pvs;
struct dm_list *pvids;
@ -2556,6 +2557,7 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
/* FIXME Also ensure contents same - checksum compare? */
if (correct_vg->seqno != vg->seqno) {
inconsistent = 1;
inconsistent_seqno = 1;
if (vg->seqno > correct_vg->seqno) {
vg_release(correct_vg);
correct_vg = vg;
@ -2679,6 +2681,7 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
/* FIXME Also ensure contents same - checksums same? */
if (correct_vg->seqno != vg->seqno) {
inconsistent = 1;
inconsistent_seqno = 1;
if (!_update_pv_list(cmd->mem, &all_pvs, vg)) {
vg_release(vg);
vg_release(correct_vg);
@ -2706,6 +2709,16 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
if (use_precommitted) {
log_error("Inconsistent pre-commit metadata copies "
"for volume group %s", vgname);
/* FIXME: during repair, there is inconsistent flag set because some metadata areas
* are missing (on missing PVs). Code should create list of missing PVs, compare it
* with PV marked missing in metadata and if equals, use it as consistent vg.
* For now, return precommited metadata if remainng seq match here to allow
* preloading table in suspend call.
*/
if (!inconsistent_seqno) {
*consistent = 0;
return correct_vg;
}
vg_release(correct_vg);
return NULL;
}