From 12949ea886259ead84597a1d4de37c8715d8edb7 Mon Sep 17 00:00:00 2001 From: David Teigland Date: Thu, 1 Apr 2021 14:37:24 -0500 Subject: [PATCH] hints: don't use hints when --sysinit is used Devices are not in a steady state during system init, so hints are repeatedly invalidated, and hardly used, so maintaining them is wasted effort. --- tools/lvmcmdline.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/lvmcmdline.c b/tools/lvmcmdline.c index 796ecfa78..23ab6fa37 100644 --- a/tools/lvmcmdline.c +++ b/tools/lvmcmdline.c @@ -2488,6 +2488,14 @@ static int _get_current_settings(struct cmd_context *cmd) if (arg_is_set(cmd, devicesfile_ARG) || arg_is_set(cmd, devices_ARG)) cmd->use_hints = 0; + /* + * During system init, hints are repeatedly invalidated due to PVs + * appearing, so it's wasted effort to try to maintain hints. + * Hints are only effective when devices are in a steady-state. + */ + if (arg_is_set(cmd, sysinit_ARG)) + cmd->use_hints = 0; + if ((hint_mode = find_config_tree_str(cmd, devices_hints_CFG, NULL))) { if (!strcmp(hint_mode, "none")) { cmd->enable_hints = 0;