shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00
Code Releases Activity

polldaemon: remove redundant log messages

Browse Source 
also alter comments describing the change in _poll_vg
wrt correct handling of multiple LVs
This commit is contained in:
Ondrej Kozina 2015-04-14 14:43:16 +02:00
parent ea5c1b0a73
commit 15a563c376
1 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/polldaemon.c
View File

@ -207,13 +207,9 @@ static int _poll_vg(struct cmd_context *cmd, const char *vgname,
if (!(sls = str_list_create(cmd->mem))) if (!(sls = str_list_create(cmd->mem)))
return ECMD_FAILED; return ECMD_FAILED;
log_verbose("Looking for pvmove LVs in VG: %s.", vg->name);
/* /*
* _check_lv_status must not be called from within any * first iterate all LVs in a VG and collect LVs suitable
* dm_list_iterate_ routine with vg->lvs as list head. * for polling (or an abort) which takes place below
* It may remove more than one LV in the process thus
* even "*_safe" variant won't help.
*/ */
dm_list_iterate_items(lvl, &vg->lvs) { dm_list_iterate_items(lvl, &vg->lvs) {
lv = lvl->lv; lv = lvl->lv;
@ -240,19 +236,13 @@ static int _poll_vg(struct cmd_context *cmd, const char *vgname,
log_error("Failed to clone pvname"); log_error("Failed to clone pvname");
goto err; goto err;
} }
log_verbose("Found LV: %s/%s. It belongs to pvmove task on PV %s.", lv->vg->name, lv->name, name);
} }
/* perform the poll operation on LVs collected in previous cycle */
dm_list_iterate_items(sl, sls) { dm_list_iterate_items(sl, sls) {
lv = parms->poll_fns->get_copy_lv(cmd, vg, sl->str, NULL, parms->lv_type); lv = parms->poll_fns->get_copy_lv(cmd, vg, sl->str, NULL, parms->lv_type);
if (lv) { if (lv && _check_lv_status(cmd, vg, lv, sl->str, parms, &finished) && !finished)
log_verbose("About to call _check_lv_status on LV: %s/%s, name: %s", parms->outstanding_count++;
lv->vg->name, lv->name, sl->str);
if (_check_lv_status(cmd, vg, lv, sl->str, parms, &finished) &&
!finished)
parms->outstanding_count++;
}
} }
err: err: