1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-27 01:55:10 +03:00

pvck: set dump on one call

arg_str_value() has built-in  arg_is_set().

Also this makes it obvious to coverity 'dump != NULL' & 'repair != NULL'
at the branch code path.
This commit is contained in:
Zdenek Kabelac 2020-05-15 15:05:39 +02:00
parent cf74123830
commit 16da6651a1

View File

@ -3065,11 +3065,9 @@ int pvck(struct cmd_context *cmd, int argc, char **argv)
label_scan_setup_bcache();
if (arg_is_set(cmd, dump_ARG)) {
if ((dump = arg_str_value(cmd, dump_ARG, NULL))) {
cmd->use_hints = 0;
dump = arg_str_value(cmd, dump_ARG, NULL);
if (!strcmp(dump, "metadata"))
ret = _dump_metadata(cmd, dump, &set, labelsector, dev, def, PRINT_CURRENT, 0);
@ -3096,11 +3094,9 @@ int pvck(struct cmd_context *cmd, int argc, char **argv)
return ECMD_PROCESSED;
}
if (arg_is_set(cmd, repairtype_ARG)) {
if ((repair = arg_str_value(cmd, repairtype_ARG, NULL))) {
cmd->use_hints = 0;
repair = arg_str_value(cmd, repairtype_ARG, NULL);
if (!strcmp(repair, "label_header"))
ret = _repair_label_header(cmd, repair, &set, labelsector, dev);