shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

thin: check only for profiled config vars

Browse Source 
ATM this rather save a lot of unncessary log entries as it grabs
the global autoextend_threshold (profile == NULL) just once instead
of revealing it every time with NULL profile.
This commit is contained in:
Zdenek Kabelac 2024-10-13 01:11:04 +02:00
parent 8fcfac7c89
commit 1755ceb17c
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/metadata/thin_manip.c
View File

@ -354,8 +354,9 @@ int thin_pool_check_overprovisioning(const struct logical_volume *lv)
struct cmd_context *cmd = lv->vg->cmd;
const char *txt = "";
uint64_t thinsum = 0, poolsum = 0, sz = ~0;
int threshold, max_threshold = 0;
int percent, min_percent = 100;
int threshold, def_threshold, max_threshold = 0;
int percent, def_percent, min_percent = 100;
struct profile *profile;
int more_pools = 0;
/* When passed thin volume, check related pool first */
@ -373,15 +374,26 @@ int thin_pool_check_overprovisioning(const struct logical_volume *lv)
return 1; /* All thins fit into this thin pool */
}
def_threshold = find_config_tree_int(cmd, activation_thin_pool_autoextend_threshold_CFG,
NULL);
def_percent = find_config_tree_int(cmd, activation_thin_pool_autoextend_percent_CFG,
NULL);
/* Sum all thins and all thin pools in VG */
dm_list_iterate_items(lvl, &lv->vg->lvs) {
if (!lv_is_thin_pool(lvl->lv))
continue;
threshold = find_config_tree_int(cmd, activation_thin_pool_autoextend_threshold_CFG,
lv_config_profile(lvl->lv));
percent = find_config_tree_int(cmd, activation_thin_pool_autoextend_percent_CFG,
lv_config_profile(lvl->lv));
if ((profile = lv_config_profile(lvl->lv))) {
threshold = find_config_tree_int(cmd, activation_thin_pool_autoextend_threshold_CFG,
profile);
percent = find_config_tree_int(cmd, activation_thin_pool_autoextend_percent_CFG,
profile);
} else {
threshold = def_threshold;
percent = def_percent;
}
if (threshold > max_threshold)
max_threshold = threshold;
if (percent < min_percent)