From 179f59a0ca7d4d5f779f86d990ebd336c9b13f0e Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Sat, 20 Mar 2021 10:39:02 +0100 Subject: [PATCH] tests: add FIXME to raid test We have here some kind of catch-22 - since older kernels do use 'resync' while new 'recover' for initial raid synchronization. So now - how do we recognize in which state of raid we are. ATM seems to be simplest to simply keep disabled droping of primary raid leg unless we are in sync. FIXME: we should add a target version check and enable removal --- test/shell/lvconvert-raid.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/shell/lvconvert-raid.sh b/test/shell/lvconvert-raid.sh index 6aaaf3669..aa50fbb62 100644 --- a/test/shell/lvconvert-raid.sh +++ b/test/shell/lvconvert-raid.sh @@ -250,7 +250,13 @@ echo "Skippen test that kills this kernel" ;; *) lvconvert --yes -m 1 $vg/$lv1 "$dev3" -lvconvert --yes -m 0 $vg/$lv1 "$dev1" + +# FIXME: it is unclear what should happen - older kernel +# do use 'resync' for initial array building so then +# we are not able to recognize difference +# Should we check version target as react differentely ?? +# Otherwise we have problem with the above test case. +should lvconvert --yes -m 0 $vg/$lv1 "$dev1" aux enable_dev "$dev2" ;; esac