shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

libdm-stats: move no regions warning after dm_stats_list()

Browse Source 
It doesn't make sense to test or warn about the region count until
the stats handle has been listed: at this point it may or may not
contain valid information (but is guaranteed to be correct after
the list).
This commit is contained in:
Bryn M. Reeves 2018-11-01 16:47:56 +00:00
parent 420af27f08
commit 19f2105b87
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libdm/libdm-stats.c
View File

@ -2338,11 +2338,6 @@ int dm_stats_populate(struct dm_stats *dms, const char *program_id,
return 0; return 0;
} }
if (!dms->nr_regions) {
log_error("No regions registered.");
return 0;
}
/* allow zero-length program_id for populate */ /* allow zero-length program_id for populate */
if (!program_id) if (!program_id)
program_id = dms->program_id; program_id = dms->program_id;
@ -2354,6 +2349,11 @@ int dm_stats_populate(struct dm_stats *dms, const char *program_id,
goto_bad; goto_bad;
} }
if (!dms->nr_regions) {
log_verbose("No stats regions registered: %s", dms->name);
return 0;
}
dms->walk_flags = DM_STATS_WALK_REGION; dms->walk_flags = DM_STATS_WALK_REGION;
dm_stats_walk_start(dms); dm_stats_walk_start(dms);
do { do {