shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-18 10:04:20 +03:00
Code Releases Activity

thin: better thin snapshot error detection

Browse Source 
While creating thin snapshot, we cannot use size argument.
This commit is contained in:
Zdenek Kabelac 2014-10-06 13:42:59 +02:00
parent 1ef660be46
commit 1a6c892864
1 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
tools/lvcreate.c
View File

@ -233,37 +233,50 @@ static int _lvcreate_name_params(struct lvcreate_params *lp,
* Normal snapshot or thinly-provisioned snapshot?
*/
static int _determine_snapshot_type(struct volume_group *vg,
struct lvcreate_params *lp)
struct lvcreate_params *lp)
{
struct lv_list *lvl;
struct logical_volume *lv, *pool_lv = NULL;
if (!(lvl = find_lv_in_vg(vg, lp->origin))) {
if (!(lv = find_lv(vg, lp->origin))) {
log_error("Snapshot origin LV %s not found in Volume group %s.",
lp->origin, vg->name);
return 0;
}
if (lv_is_cache(lvl->lv)) {
if (lv_is_cache(lv)) {
log_error("Snapshot of cache LV is not yet supported.");
return 0;
}
if (lp->pool) {
if (!(pool_lv = find_lv(vg, lp->pool))) {
log_error("Thin pool volume %s not found in Volume group %s.",
lp->pool, vg->name);
return 0;
}
if (!lv_is_thin_pool(pool_lv)) {
log_error("Logical volume %s is not a thin pool volume.",
display_lvname(pool_lv));
return 0;
}
}
if (!arg_count(vg->cmd, extents_ARG) && !arg_count(vg->cmd, size_ARG)) {
if (seg_is_thin(lp)) {
if (lv_is_thin_volume(lv) && !lp->pool)
lp->pool = first_seg(lv)->pool_lv->name;
if (seg_is_thin(lp) || lp->pool) {
if (!(lp->segtype = get_segtype_from_string(vg->cmd, "thin")))
return_0;
return 1;
}
if (!lv_is_thin_volume(lvl->lv)) {
log_error("Please specify either size or extents with snapshots.");
return 0;
}
if (!(lp->segtype = get_segtype_from_string(vg->cmd, "thin")))
return_0;
lp->pool = first_seg(lvl->lv)->pool_lv->name;
log_error("Please specify either size or extents with snapshots.");
return 0;
} else if (lp->pool) {
log_error("Cannot specify size with thin pool snapshot.");
return 0;
}
return 1;