From 1c200869d9a791e39612271f101701b56843a165 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 28 Jul 2007 10:27:34 +0000 Subject: [PATCH] Make the libdevmapper version of create_dir equivalent to the LVM2 one. (_create_dir_recursive): Refrain from logging a mkdir failure due to EROFS. Patch by Jun'ichi Nomura. --- WHATS_NEW_DM | 1 + libdm/libdm-file.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index 829d9e9a3..be0af5c2a 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,5 +1,6 @@ Version 1.02.22 - ================================ + Don't log mkdir fail-with-EROFS, to make create_dir equiv to the one in LVM2 Introduce and use log_sys_* macros from LVM2 dm_fclose: new function libdevmapper, dmeventd: be paranoid about detecting write failure diff --git a/libdm/libdm-file.c b/libdm/libdm-file.c index 38dabb633..bff722a5b 100644 --- a/libdm/libdm-file.c +++ b/libdm/libdm-file.c @@ -33,7 +33,8 @@ static int _create_dir_recursive(const char *dir) if (*orig) { rc = mkdir(orig, 0777); if (rc < 0 && errno != EEXIST) { - log_sys_error("mkdir", orig); + if (errno != EROFS) + log_sys_error("mkdir", orig); goto out; } } @@ -43,7 +44,8 @@ static int _create_dir_recursive(const char *dir) /* Create final directory */ rc = mkdir(dir, 0777); if (rc < 0 && errno != EEXIST) { - log_sys_error("mkdir", orig); + if (errno != EROFS) + log_sys_error("mkdir", orig); goto out; }