shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-08 08:58:50 +03:00
Code Releases Activity

lvdisplay: dispaly correct status when underlying devs missing

Browse Source 
reproducible steps:
1. vgcreate vg1 /dev/sda /dev/sdb
2. lvcreate --type raid0 -l 100%FREE -n raid0lv vg1
3. do remove the /dev/sdb action
4. lvdisplay show wrong 'LV Status'

After removing raid0 type LV underlying dev, lvdisplay still display
'available'. This is wrong status for raid0.

This patch add a new function raid_is_available(), which will handle
all raid case.

With this patch, lvdisplay will show
from:
  LV Status              available
to:
  LV Status              NOT available (partial)

Reviewed-by: Enzo Matsumiya <ematsumiya@suse.com>
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
This commit is contained in:
Zhao Heming 2020-08-24 09:47:04 -05:00 committed by David Teigland
parent 46d15b5e4d
commit 1d0dc74f91
3 changed files with 65 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/display/display.c
View File

@ -399,7 +399,7 @@ int lvdisplay_full(struct cmd_context *cmd,
void *handle __attribute__((unused)))
{
struct lvinfo info;
int inkernel, snap_active = 0;
int inkernel, snap_active = 0, partial = 0, raid_is_avail = 1;
char uuid[64] __attribute__((aligned(8)));
const char *access_str;
struct lv_segment *snap_seg = NULL, *mirror_seg = NULL;
@ -553,11 +553,18 @@ int lvdisplay_full(struct cmd_context *cmd,
log_print("LV VDO Pool name %s", seg_lv(seg, 0)->name);
}
if (lv_is_partial(lv)) {
partial = 1;
if (lv_is_raid(lv))
raid_is_avail = raid_is_available(lv) ? 1 : 0;
}
if (inkernel && info.suspended)
log_print("LV Status suspended");
else if (activation())
log_print("LV Status %savailable",
inkernel ? "" : "NOT ");
log_print("LV Status %savailable %s",
(inkernel && raid_is_avail) ? "" : "NOT ",
partial ? "(partial)" : "");
/********* FIXME lv_number
log_print("LV # %u", lv->lv_number + 1);

1
lib/metadata/segtype.h
View File

@ -326,6 +326,7 @@ struct segment_type *init_unknown_segtype(struct cmd_context *cmd,
#ifdef RAID_INTERNAL
int init_raid_segtypes(struct cmd_context *cmd, struct segtype_library *seglib);
bool raid_is_available(const struct logical_volume *lv);
#endif
#define THIN_FEATURE_DISCARDS (1U << 0)

54
lib/raid/raid.c
View File

@ -25,6 +25,60 @@
#include "lib/metadata/metadata.h"
#include "lib/metadata/lv_alloc.h"
/*
* below case think as available, return true:
* - raid 1: at least 1 disk live
* - raid 10: loose 1 disk
* - raid 4/5: loose 1 disk
* - raid 6: loose 2 disk
*
* raid 0: if there is any disk loose, return false
* */
bool raid_is_available(const struct logical_volume *lv)
{
int s, missing_pv = 0, exist_pv = 0;
bool ret = true;
struct lv_segment *seg = NULL;
dm_list_iterate_items(seg, &lv->segments) {
for (s = 0; s < seg->area_count; ++s) {
if (seg_type(seg, s) == AREA_LV) {
if (seg_lv(seg, s)->status & PARTIAL_LV)
missing_pv++;
else
exist_pv++;
}
}
}
if (seg_is_any_raid0(first_seg(lv))){
ret = missing_pv ? false : true;
goto out;
}
if (seg_is_raid1(first_seg(lv))){
ret = exist_pv ? true : false;
goto out;
}
if (seg_is_any_raid10(first_seg(lv))) {
ret = (missing_pv > 1) ? false : true;
goto out;
}
if (seg_is_raid4(first_seg(lv))) {
ret = (missing_pv > 1) ? false : true;
goto out;
}
if (seg_is_any_raid5(first_seg(lv))) {
ret = (missing_pv > 1) ? false : true;
goto out;
}
if (seg_is_any_raid6(first_seg(lv))) {
ret = (missing_pv > 2) ? false : true;
goto out;
}
out:
return ret;
}
static int _raid_target_present(struct cmd_context *cmd,
const struct lv_segment *seg __attribute__((unused)),
unsigned *attributes);