shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-02-25 21:57:45 +03:00
Code Releases Activity

lv_manip: move some validation code before archiving

Browse Source 
Make as much test we can, before actualy modifying metadata.
Avoids also unnecessary archiving.
This commit is contained in:
Zdenek Kabelac 2013-07-17 14:52:21 +02:00
parent 7b4b97b731
commit 1d3f7953bd
1 changed files with 33 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
lib/metadata/lv_manip.c
View File

@ -5355,6 +5355,21 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
return NULL;
}
if (vg_is_clustered(vg) && segtype_is_raid(lp->segtype)) {
/*
* FIXME:
* We could allow a RAID LV to be created as long as it
* is activated exclusively. Any subsequent activations
* would have to be enforced as exclusive also.
*
* For now, we disallow the existence of RAID LVs in a
* cluster VG
*/
log_error("Unable to create a %s logical volume in a cluster.",
lp->segtype->name);
return NULL;
}
if ((segtype_is_mirrored(lp->segtype) ||
segtype_is_raid(lp->segtype) || segtype_is_thin(lp->segtype)) &&
!(vg->fid->fmt->features & FMT_SEGMENTS)) {
@ -5540,9 +5555,6 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
!(lp->segtype = get_segtype_from_string(cmd, "striped")))
return_NULL;
if (!archive(vg))
return_NULL;
if (!dm_list_empty(&lp->tags)) {
if (!(vg->fid->fmt->features & FMT_TAGS)) {
log_error("Volume group %s does not support tags",
@ -5551,6 +5563,9 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
}
}
if (!archive(vg))
return_NULL;
if (seg_is_thin_volume(lp)) {
/* Ensure all stacked messages are submitted */
if (!(lvl = find_lv_in_vg(vg, lp->pool))) {
@ -5558,25 +5573,26 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
lp->pool, vg->name);
return NULL;
}
if (lv_is_active_locally(lvl->lv) &&
!pool_below_threshold(first_seg(lvl->lv))) {
log_error("Cannot create thin volume. Pool \"%s/%s\" "
"is filled over the autoextend threshold.",
lvl->lv->vg->name, lvl->lv->name);
return NULL;
}
if (lv_is_active(lvl->lv) ||
((lp->activate != CHANGE_AN) && (lp->activate != CHANGE_ALN)))
if (!update_pool_lv(lvl->lv, 1))
return_NULL;
}
if (vg_is_clustered(vg) && segtype_is_raid(lp->segtype)) {
/*
* FIXME:
* We could allow a RAID LV to be created as long as it
* is activated exclusively. Any subsequent activations
* would have to be enforced as exclusive also.
*
* For now, we disallow the existence of RAID LVs in a
* cluster VG
*/
log_error("Unable to create a %s logical volume in a cluster.",
lp->segtype->name);
return NULL;
/* For thin snapshot we must have matching pool */
if (org && lv_is_thin_volume(org) && (!lp->pool ||
(strcmp(first_seg(org)->pool_lv->name, lp->pool) == 0)))
thin_name = org->name;
else
thin_name = lp->pool;
}
if (segtype_is_mirrored(lp->segtype) || segtype_is_raid(lp->segtype)) {
@ -5613,15 +5629,6 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
dm_list_splice(&lv->tags, &lp->tags);
if (seg_is_thin_volume(lp)) {
/* For thin snapshot we must have matching pool */
if (org && lv_is_thin_volume(org) && (!lp->pool ||
(strcmp(first_seg(org)->pool_lv->name, lp->pool) == 0)))
thin_name = org->name;
else
thin_name = lp->pool;
}
if (!lv_extend(lv, lp->segtype,
lp->stripes, lp->stripe_size,
lp->mirrors,
@ -5714,12 +5721,6 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
if (seg_is_thin(lp)) {
/* For snapshot, suspend active thin origin first */
if (org && lv_is_active(org) && lv_is_thin_volume(org)) {
if (!pool_below_threshold(first_seg(first_seg(org)->pool_lv))) {
log_error("Cannot create thin snapshot. Pool %s/%s is filled "
"over the autoextend threshold.",
org->vg->name, first_seg(org)->pool_lv->name);
goto revert_new_lv;
}
if (!suspend_lv_origin(cmd, org)) {
log_error("Failed to suspend thin snapshot origin %s/%s.",
org->vg->name, org->name);