shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-28 02:50:41 +03:00
Code Releases Activity

Use pv from newly read_vg to avoid possible use of not initialized memory.

Browse Source 
If the vg in process_each_segment_in_pv is NULL, the pv struct
can be incomplete (for example lv_segs are not copied in get_pvs()
call).

We need use the new pv from just read-in volume group.

(The same code is in pvdisplay already.)
This commit is contained in:
Milan Broz 2009-04-07 10:22:14 +00:00
parent 0c4379ff0f
commit 2112fc571a
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/toollib.c
View File

@ -364,6 +364,7 @@ int process_each_segment_in_pv(struct cmd_context *cmd,
void *handle))
{
struct pv_segment *pvseg;
struct pv_list *pvl;
const char *vg_name = NULL;
int ret_max = ECMD_PROCESSED;
int ret;
@ -376,6 +377,18 @@ int process_each_segment_in_pv(struct cmd_context *cmd,
log_error("Skipping volume group %s", vg_name);
return ECMD_FAILED;
}
/*
* Replace possibly incomplete PV structure with new one
* allocated in vg_read_internal() path.
*/
if (!(pvl = find_pv_in_vg(vg, pv_dev_name(pv)))) {
log_error("Unable to find %s in volume group %s",
pv_dev_name(pv), vg_name);
return ECMD_FAILED;
}
pv = pvl->pv;
}
dm_list_iterate_items(pvseg, &pv->segments) {