1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00

lockd: note that external origins don't work in lockd VGs

in a comment at the point where it fails, and in the
lvmlockd man page.
This commit is contained in:
David Teigland 2015-07-10 13:27:02 -05:00
parent b8538f5dcd
commit 222bb2b88d
2 changed files with 12 additions and 0 deletions

View File

@ -686,6 +686,8 @@ Things that do not yet work in lockd VGs:
.br .br
- using lvcreate to create cache pools or cache LVs (use lvconvert) - using lvcreate to create cache pools or cache LVs (use lvconvert)
.br .br
- using external origins for thin LVs
.br
- splitting mirrors and snapshots from LVs - splitting mirrors and snapshots from LVs
.br .br
- vgsplit - vgsplit

View File

@ -2533,6 +2533,16 @@ static int _lvconvert_thin(struct cmd_context *cmd,
} }
if (is_lockd_type(lv->vg->lock_type)) { if (is_lockd_type(lv->vg->lock_type)) {
/*
* FIXME: external origins don't work in lockd VGs.
* Prior to the lvconvert, there's a lock associated with
* the uuid of the external origin LV. After the convert,
* that uuid belongs to the new thin LV, and a new LV with
* a new uuid exists as the non-thin, readonly external LV.
* We'd need to remove the lock for the previous uuid
* (the new thin LV will have no lock), and create a new
* lock for the new LV uuid used by the external LV.
*/
log_error("Can't use lock_type %s LV as external origin.", log_error("Can't use lock_type %s LV as external origin.",
lv->vg->lock_type); lv->vg->lock_type);
return 0; return 0;