From 254944d8905ac7ff5df250bf50ebe39c84301c3a Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Wed, 25 Jan 2012 22:20:11 +0000 Subject: [PATCH] Set to a defined value vars used after error path Static analyzer noticed this vars are used even when error is reported back thus their state is undefined - set to 0 for this case. --- daemons/clvmd/clvmd-command.c | 2 +- tools/lvmdiskscan.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/daemons/clvmd/clvmd-command.c b/daemons/clvmd/clvmd-command.c index cdfaea081..e6c5da10d 100644 --- a/daemons/clvmd/clvmd-command.c +++ b/daemons/clvmd/clvmd-command.c @@ -257,7 +257,7 @@ int do_pre_command(struct local_client *client) unsigned char lock_cmd; unsigned char lock_flags; char *args = header->node + strlen(header->node) + 1; - int lockid; + int lockid = 0; int status = 0; char *lockname; diff --git a/tools/lvmdiskscan.c b/tools/lvmdiskscan.c index a35667e00..4f10ae1e2 100644 --- a/tools/lvmdiskscan.c +++ b/tools/lvmdiskscan.c @@ -81,6 +81,7 @@ static int _check_device(struct cmd_context *cmd, struct device *dev) } if (!dev_get_size(dev, &size)) { log_error("Couldn't get size of \"%s\"", dev_name(dev)); + size = 0; } _print(cmd, dev, size, NULL); _count(dev, &disks_found, &parts_found);