shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

libdm: log_warn

Browse Source 
No real effect anyway - function returs '1' in all paths,
but just make sure we do not have 'log_error()' on non-error path.
This commit is contained in:
Zdenek Kabelac 2017-07-24 14:40:41 +02:00
parent c1b5f38bbe
commit 2593777f65
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libdm/libdm-deptree.c
View File

@ -938,7 +938,7 @@ static int _info_by_dev(uint32_t major, uint32_t minor, int with_open_count,
} }
if (!with_open_count && !dm_task_no_open_count(dmt)) if (!with_open_count && !dm_task_no_open_count(dmt))
log_error("Failed to disable open_count"); log_warn("WARNING: Failed to disable open_count.");
if (!(r = dm_task_run(dmt))) if (!(r = dm_task_run(dmt)))
goto_out; goto_out;
@ -1053,7 +1053,7 @@ static int _deactivate_node(const char *name, uint32_t major, uint32_t minor,
} }
if (!dm_task_no_open_count(dmt)) if (!dm_task_no_open_count(dmt))
log_error("Failed to disable open_count"); log_warn("WARNING: Failed to disable open_count.");
if (cookie) if (cookie)
if (!dm_task_set_cookie(dmt, cookie, udev_flags)) if (!dm_task_set_cookie(dmt, cookie, udev_flags))
@ -1343,7 +1343,7 @@ static int _rename_node(const char *old_name, const char *new_name, uint32_t maj
goto_out; goto_out;
if (!dm_task_no_open_count(dmt)) if (!dm_task_no_open_count(dmt))
log_error("Failed to disable open_count"); log_warn("WARNING: Failed to disable open_count.");
if (!dm_task_set_cookie(dmt, cookie, udev_flags)) if (!dm_task_set_cookie(dmt, cookie, udev_flags))
goto out; goto out;
@ -1384,10 +1384,10 @@ static int _resume_node(const char *name, uint32_t major, uint32_t minor,
} }
if (!dm_task_no_open_count(dmt)) if (!dm_task_no_open_count(dmt))
log_error("Failed to disable open_count"); log_warn("WARNING: Failed to disable open_count.");
if (!dm_task_set_read_ahead(dmt, read_ahead, read_ahead_flags)) if (!dm_task_set_read_ahead(dmt, read_ahead, read_ahead_flags))
log_error("Failed to set read ahead"); log_warn("WARNING: Failed to set read ahead.");
if (!dm_task_set_cookie(dmt, cookie, udev_flags)) if (!dm_task_set_cookie(dmt, cookie, udev_flags))
goto_out; goto_out;
@ -1430,13 +1430,13 @@ static int _suspend_node(const char *name, uint32_t major, uint32_t minor,
} }
if (!dm_task_no_open_count(dmt)) if (!dm_task_no_open_count(dmt))
log_error("Failed to disable open_count"); log_warn("WARNING: Failed to disable open_count.");
if (skip_lockfs && !dm_task_skip_lockfs(dmt)) if (skip_lockfs && !dm_task_skip_lockfs(dmt))
log_error("Failed to set skip_lockfs flag."); log_warn("WARNING: Failed to set skip_lockfs flag.");
if (no_flush && !dm_task_no_flush(dmt)) if (no_flush && !dm_task_no_flush(dmt))
log_error("Failed to set no_flush flag."); log_warn("WARNING: Failed to set no_flush flag.");
if ((r = dm_task_run(dmt))) { if ((r = dm_task_run(dmt))) {
inc_suspended(); inc_suspended();
@ -1467,7 +1467,7 @@ static int _thin_pool_get_status(struct dm_tree_node *dnode,
} }
if (!dm_task_no_flush(dmt)) if (!dm_task_no_flush(dmt))
log_warn("Can't set no_flush flag."); /* Non fatal */ log_warn("WARNING: Can't set no_flush flag."); /* Non fatal */
if (!dm_task_run(dmt)) if (!dm_task_run(dmt))
goto_out; goto_out;
@ -2031,7 +2031,7 @@ static int _create_node(struct dm_tree_node *dnode)
} }
if (!dm_task_no_open_count(dmt)) if (!dm_task_no_open_count(dmt))
log_error("Failed to disable open_count"); log_warn("WARNING: Failed to disable open_count.");
if ((r = dm_task_run(dmt))) { if ((r = dm_task_run(dmt))) {
if (!(r = dm_task_get_info(dmt, &dnode->info))) if (!(r = dm_task_get_info(dmt, &dnode->info)))