From 26c58027fb9df068c927abe61336ff6364fe3d0e Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Sat, 17 Mar 2018 13:53:12 +0100 Subject: [PATCH] coverity: validate descriptor Since this function is called with 'fd == -1', but Coverity can't see this path can't be visited with this argument, add explicit check for valid descriptor. --- daemons/clvmd/clvmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/daemons/clvmd/clvmd.c b/daemons/clvmd/clvmd.c index e15a40a6d..829c5e5f8 100644 --- a/daemons/clvmd/clvmd.c +++ b/daemons/clvmd/clvmd.c @@ -1999,6 +1999,9 @@ static int send_message(void *buf, int msglen, const char *csid, int fd, return clops->cluster_send_message(buf, msglen, csid, errtext); } + if (fd < 0) + return 0; + /* Make sure it all goes */ for (ptr = 0; ptr < msglen;) { if ((len = write(fd, (char*)buf + ptr, msglen - ptr)) <= 0) {