shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvconvert: limit libdm to maximum of 64 RAID devices

Browse Source 
Commit 64a2fad5d6 raised the maximum number of RAID devices to 64.

Commit e2354ea344 introduced RAID_BITMAP_SIZE as 4 to have
256 bits (4 * 64 bit array members), thus changing the libdm API
unnecessarilly for the time being.

To not change the API, reduce RAID_BITMAP_SIZE to 1.
Remove an unneeded definition of it from libdm-common.h.

If we ever decide to raise past 64, we'll version the API.

Related: rhbz834579
Related: rhbz1191935
Related: rhbz1191978
This commit is contained in:
Heinz Mauelshagen 2017-02-27 21:42:15 +01:00
parent c41e999488
commit 27384c52cf
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libdm/libdevmapper.h
View File

@ -1739,7 +1739,16 @@ int dm_tree_node_add_raid_target(struct dm_tree_node *node,
*/ */
#define DM_CACHE_METADATA_MAX_SECTORS DM_THIN_METADATA_MAX_SECTORS #define DM_CACHE_METADATA_MAX_SECTORS DM_THIN_METADATA_MAX_SECTORS
#define RAID_BITMAP_SIZE 4 /*
* Define number of elements in rebuild and writemostly arrays
* 'of struct dm_tree_node_raid_params'.
*
* Set to one to keep the current libdm API!
*
* If we ever raise the maximum number of RAID devices past 64 thus
* changing the API, we have to version it for backwards API compatibility.
*/
#define RAID_BITMAP_SIZE 1
struct dm_tree_node_raid_params { struct dm_tree_node_raid_params {
const char *raid_type; const char *raid_type;

2
libdm/libdm-common.h
View File

@ -23,8 +23,6 @@
#define DEV_NAME(dmt) (dmt->mangled_dev_name ? : dmt->dev_name) #define DEV_NAME(dmt) (dmt->mangled_dev_name ? : dmt->dev_name)
#define DEV_UUID(DMT) (dmt->mangled_uuid ? : dmt->uuid) #define DEV_UUID(DMT) (dmt->mangled_uuid ? : dmt->uuid)
#define RAID_BITMAP_SIZE 4
int mangle_string(const char *str, const char *str_name, size_t len, int mangle_string(const char *str, const char *str_name, size_t len,
char *buf, size_t buf_len, dm_string_mangling_t mode); char *buf, size_t buf_len, dm_string_mangling_t mode);