From 28658541daef567f0f767190c244a100ea45476f Mon Sep 17 00:00:00 2001 From: "Bryn M. Reeves" Date: Wed, 6 Jul 2016 11:10:23 +0100 Subject: [PATCH] libdm: do not permit grouping regions with histograms Although not harmful do not allow a group containing regions with histograms since it is not currently possible to present histogram data aggregated for the group. --- libdm/libdm-stats.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c index c669b5111..06aa64566 100644 --- a/libdm/libdm-stats.c +++ b/libdm/libdm-stats.c @@ -3767,7 +3767,11 @@ int dm_stats_create_group(struct dm_stats *dms, const char *members, FMTu64, i, dms->regions[i].group_id); goto bad; } - + if (dms->regions[i].bounds) { + log_error("Region ID %d: grouping regions with " + "histograms is not yet supported", i); + goto bad; + } if (dms->regions[i].timescale == 1) precise++;