shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-27 10:25:13 +03:00
Code Releases Activity

Add pvcreate_params to vg_extend.

Browse Source 
Another refactoring for implicit pvcreate support.  We need to get
the pvcreate parameters somehow to the vg_extend routine.  Options
seemed to be:
1. Attach the parameters to struct volume_group.  I personally
did not like this idea in most cases, though one could make an
agrument why it might be ok at least for some of the parameters
(e.g. metadatacopies).
2. Pass them in to the extend routine.  This second route seemed
to be the best approach given the constraints.

Future patches will parse the command line and fill in the actual
values for the pvcreate_single call.
Should be no functional change.
This commit is contained in:
Dave Wysochanski 2009-10-05 20:02:48 +00:00
parent acb4073eed
commit 29123aa652
5 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/metadata/metadata-exported.h
View File

@ -453,7 +453,8 @@ int vg_remove_check(struct volume_group *vg);
int vg_remove(struct volume_group *vg);
int vg_rename(struct cmd_context *cmd, struct volume_group *vg,
const char *new_name);
int vg_extend(struct volume_group *vg, int pv_count, char **pv_names);
int vg_extend(struct volume_group *vg, int pv_count, char **pv_names,
struct pvcreate_params *pp);
int vg_reduce(struct volume_group *vg, char *pv_name);
int vg_set_extent_size(struct volume_group *vg, uint32_t new_extent_size);
int vg_set_max_lv(struct volume_group *vg, uint32_t max_lv);

15
lib/metadata/metadata.c
View File

@ -582,7 +582,18 @@ static int vg_extend_single_pv(struct volume_group *vg, char *pv_name,
return 1;
}
int vg_extend(struct volume_group *vg, int pv_count, char **pv_names)
/*
* Extend a VG by a single PV / device path
*
* Parameters:
* - vg: handle of volume group to extend by 'pv_name'
* - pv_count: count of device paths of PVs
* - pv_names: device paths of PVs to add to VG
* - pp: parameters to pass to implicit pvcreate; if NULL, do not pvcreate
*
*/
int vg_extend(struct volume_group *vg, int pv_count, char **pv_names,
struct pvcreate_params *pp)
{
int i;
@ -591,7 +602,7 @@ int vg_extend(struct volume_group *vg, int pv_count, char **pv_names)
/* attach each pv */
for (i = 0; i < pv_count; i++) {
if (!vg_extend_single_pv(vg, pv_names[i], NULL))
if (!vg_extend_single_pv(vg, pv_names[i], pp))
goto bad;
}

2
liblvm/lvm_vg.c
View File

@ -60,7 +60,7 @@ int lvm_vg_extend(vg_t vg, const char *device)
return -1;
}
if (!vg_extend(vg, 1, (char **) &device)) {
if (!vg_extend(vg, 1, (char **) &device, NULL)) {
unlock_vg(vg->cmd, VG_ORPHANS);
return -1;
}

2
tools/vgcreate.c
View File

@ -63,7 +63,7 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
}
/* attach the pv's */
if (!vg_extend(vg, argc - 1, argv + 1))
if (!vg_extend(vg, argc - 1, argv + 1, NULL))
goto_bad;
if (vp_new.max_lv != vg->max_lv)

2
tools/vgextend.c
View File

@ -54,7 +54,7 @@ int vgextend(struct cmd_context *cmd, int argc, char **argv)
goto_bad;
/* extend vg */
if (!vg_extend(vg, argc, argv))
if (!vg_extend(vg, argc, argv, NULL))
goto_bad;
/* ret > 0 */