shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-06 00:58:48 +03:00
Code Releases Activity

Improve lv_extend stack reporting

Browse Source 
and some code cleanup with setting return value.
This commit is contained in:
Zdenek Kabelac 2011-10-28 20:23:24 +00:00
parent c590a9cdbc
commit 2b71bcd0cb
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.89 -
==================================
Improve lv_extend stack reporting.
Increase virtual segment size instead of creating multiple segment list.
Add last_seg(lv) internal function.
Support empty string for log/prefix.

22
lib/metadata/lv_manip.c
View File

@ -2571,10 +2571,11 @@ int lv_extend(struct logical_volume *lv,
if (segtype_is_thin_pool(segtype)) {
if (!(r = extend_pool(lv, segtype, ah)))
stack;
} else if (!segtype_is_mirrored(segtype) && !segtype_is_raid(segtype))
r = lv_add_segment(ah, 0, ah->area_count, lv, segtype,
stripe_size, 0u, 0);
else {
} else if (!segtype_is_mirrored(segtype) && !segtype_is_raid(segtype)) {
if (!(r = lv_add_segment(ah, 0, ah->area_count, lv, segtype,
stripe_size, 0u, 0)))
stack;
} else {
/*
* For RAID, all the devices are AREA_LV.
* However, for 'mirror on stripe' using non-RAID targets,
@ -2587,11 +2588,10 @@ int lv_extend(struct logical_volume *lv,
sub_lv_count = mirrors;
if (!lv->le_count &&
!_lv_insert_empty_sublvs(lv, segtype, stripe_size,
region_size, sub_lv_count)) {
!(r = _lv_insert_empty_sublvs(lv, segtype, stripe_size,
region_size, sub_lv_count))) {
log_error("Failed to insert layer for %s", lv->name);
alloc_destroy(ah);
return 0;
goto out;
}
if (!(r = _lv_extend_layered_lv(ah, lv, extents, 0,
@ -2620,9 +2620,8 @@ int lv_extend(struct logical_volume *lv,
goto out;
}
r = 0;
if (!lv_mirror_percent(lv->vg->cmd, lv, 0,
&sync_percent, NULL)) {
if (!(r = lv_mirror_percent(lv->vg->cmd, lv, 0,
&sync_percent, NULL))) {
log_error("Failed to get sync percent for %s/%s",
lv->vg->name, lv->name);
goto out;
@ -2638,7 +2637,6 @@ int lv_extend(struct logical_volume *lv,
lv->vg->name, lv->name);
goto out;
}
r = 1;
}
}