shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-27 18:55:19 +03:00
Code Releases Activity

man-generator: enhance performance

Browse Source 
Set block buffering on stdout to
save ~30% time generating manuals.
This commit is contained in:
Heinz Mauelshagen 2017-03-30 19:55:50 +02:00
parent 0da040b1eb
commit 2c4e8254de
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tools/command.c
View File

@ -3418,13 +3418,17 @@ static void _print_man_secondary(char *name)
}
}
#define STDOUT_BUF_SIZE (MAX_MAN_DESC + 4 * 1024)
int main(int argc, char *argv[])
{
char *cmdname = NULL;
char *desfile = NULL;
char *stdout_buf;
int primary = 0;
int secondary = 0;
int r = 1;
int r = 0;
size_t sz = STDOUT_BUF_SIZE;
static struct option long_options[] = {
{"primary", no_argument, 0, 'p' },
@ -3434,6 +3438,11 @@ int main(int argc, char *argv[])
memset(&commands, 0, sizeof(commands));
if (!(stdout_buf = dm_malloc(sz)))
log_error("Failed to allocate stdout buffer; carrying on with default buffering.");
else
setbuffer(stdout, stdout_buf, sz);
while (1) {
int c;
int option_index = 0;
@ -3456,14 +3465,14 @@ int main(int argc, char *argv[])
if (!primary && !secondary) {
log_error("Usage: %s --primary|--secondary <command> [/path/to/description-file].", argv[0]);
goto out;
goto out_free;
}
if (optind < argc)
cmdname = strdup(argv[optind++]);
else {
log_error("Missing command name.");
goto out;
goto out_free;
}
if (optind < argc)
@ -3477,10 +3486,15 @@ int main(int argc, char *argv[])
if (primary)
r = _print_man(cmdname, desfile, secondary);
else if (secondary)
else if (secondary) {
r = 1;
_print_man_secondary(cmdname);
}
out_free:
if (stdout_buf)
free(stdout_buf);
out:
exit(r ? EXIT_SUCCESS: EXIT_FAILURE);
}