shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-11 20:58:50 +03:00
Code Releases Activity

lvmlockd: always disallow mirror splitting

Browse Source 
lv_raid_split() was correctly prevented in a shared VG,
but lv_raid_split_and_track() was missing that check.
This commit is contained in:
David Teigland 2017-09-05 10:26:58 -05:00
parent 09c792c206
commit 3071837e21
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.174 - Version 2.02.174 -
================================= =================================
Prevent raid1 split with trackchanges in a shared VG.
Avoid double unlocking of client & lockspace mutexes in lvmlockd. Avoid double unlocking of client & lockspace mutexes in lvmlockd.
Fix leaking of file descriptor for non-blocking filebased locking. Fix leaking of file descriptor for non-blocking filebased locking.
Fix check for 2nd mda at end of disk fits if using pvcreate --restorefile. Fix check for 2nd mda at end of disk fits if using pvcreate --restorefile.

6
lib/metadata/raid_manip.c
View File

@ -3426,6 +3426,12 @@ int lv_raid_split_and_track(struct logical_volume *lv,
int s; int s;
struct lv_segment *seg = first_seg(lv); struct lv_segment *seg = first_seg(lv);
if (is_lockd_type(lv->vg->lock_type)) {
log_error("Splitting raid image is not allowed with lock_type %s.",
lv->vg->lock_type);
return 0;
}
if (!seg_is_mirrored(seg)) { if (!seg_is_mirrored(seg)) {
log_error("Unable to split images from non-mirrored RAID."); log_error("Unable to split images from non-mirrored RAID.");
return 0; return 0;