shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-18 10:04:20 +03:00
Code Releases Activity

thin: raise required version to 1.4

Browse Source 
Stay safe and require 1.4 (kernel 3.6) for non-power-of-2
support for thin pool chunk_size.
This commit is contained in:
Zdenek Kabelac 2012-10-11 14:07:35 +02:00
parent 57460fe5a8
commit 316ce655a3
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/thin/thin.c
View File

@ -244,7 +244,7 @@ static int _thin_pool_add_target_line(struct dev_manager *dm,
if (!(attr & THIN_FEATURE_BLOCK_SIZE) &&
(seg->chunk_size & (seg->chunk_size - 1))) {
log_error("Thin pool target does not support %uKiB chunk size "
"(needs kernel >= 3.5).", seg->chunk_size / 2);
"(needs kernel >= 3.6).", seg->chunk_size / 2);
return 0;
}
@ -559,7 +559,7 @@ static int _thin_target_present(struct cmd_context *cmd,
/* FIXME Log this as WARNING later only if the user asked for the feature to be used but it's not present */
log_debug("Target " THIN_MODULE " does not support external origins.");
if (maj >=1 && min >= 2)
if (maj >=1 && min >= 4)
_attrs |= THIN_FEATURE_BLOCK_SIZE;
else
/* FIXME Log this as WARNING later only if the user asked for the feature to be used but it's not present */

2
man/lvcreate.8.in
View File

@ -133,7 +133,7 @@ For thin pools the value must be between 64KiB and
1048576KiB and the default value starts with 64 and scales
up to fit the pool metadata size within 128MB,
if the poolmetadata size is not specified.
Older dm thin pool target version (<1.2) requires the value to be power of 2.
Older dm thin pool target version (<1.4) requires the value to be power of 2.
The newer version requires to be the multiple of 64KiB, however discard is
not supported for non power of 2 values.
Default unit is in kilobytes.

2
test/shell/lvcreate-thin-power2.sh
View File

@ -18,7 +18,7 @@
#
# Main
#
aux have_thin 1 2 0 || skip
aux have_thin 1 4 0 || skip
aux prepare_pvs 2 64