shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Fix convert polling to ignore LV with different UUID.

Browse Source 
When mirror convert polling is started (mainly as backgound process,
in lvchange -a y or in lvconvert itself) it tries to read VG
and LV identified by its name.

Unfortunatelly, the VG can have already different LV under the same name,
and various more or less funny things can happen (note that
_finish_lvconvert_mirror suspends the volume for example).

(the typical example is our testing script which continuously recreates
LVs under the same name in the same VG.)

This patch adds optional uuid parameter which helps to properly
select the monitoring object. For lvconvert polling it is set to LV UUID
and both _get_lvconvert_vg and _get_lvconvert_lv uses it to read proper VG/LV.

(In the pvmove case it is NULL, here we poll for physical volume name).
This commit is contained in:
Milan Broz 2009-06-01 14:43:27 +00:00
parent 59d06d4dc7
commit 31f55a07db
10 changed files with 63 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.48 -
===============================
Fix convert polling to ignore LV with different UUID.
Cache underlying device readahead only before activation calls.
Fix segfault when calculating readahead on missing device in vgreduce.
Remove verbose 'visited' messages.

1
lib/metadata/metadata-exported.h
View File

@ -621,6 +621,7 @@ struct logical_volume *find_pvmove_lv(struct volume_group *vg,
struct logical_volume *find_pvmove_lv_from_pvname(struct cmd_context *cmd,
struct volume_group *vg,
const char *name,
const char *uuid,
uint32_t lv_type);
const char *get_pvmove_pvname_from_lv(struct logical_volume *lv);
const char *get_pvmove_pvname_from_lv_mirr(struct logical_volume *lv_mirr);

7
lib/metadata/mirror.c
View File

@ -1058,9 +1058,10 @@ struct logical_volume *find_pvmove_lv(struct volume_group *vg,
}
struct logical_volume *find_pvmove_lv_from_pvname(struct cmd_context *cmd,
struct volume_group *vg,
const char *name,
uint32_t lv_type)
struct volume_group *vg,
const char *name,
const char *uuid __attribute((unused)),
uint32_t lv_type)
{
struct physical_volume *pv;

27
test/t-mirror-lvconvert.sh
View File

@ -280,20 +280,19 @@ mirrorlog_is_on_ $vg/$lv1 $dev3
check_and_cleanup_lvs_
# "remove from original mirror (the original becomes linear)"
# FIXME: enable this test later
#prepare_lvs_
#lvcreate -l2 -m1 -n $lv1 $vg $dev1 $dev2 $dev3:0-1
#check_mirror_count_ $vg/$lv1 2
#check_mirror_log_ $vg/$lv1
#lvconvert -m+1 -b $vg/$lv1 $dev4
#lvconvert -m-1 $vg/$lv1 $dev2
#lvconvert -i1 $vg/$lv1
#wait_conversion_ $vg/$lv1
#check_no_tmplvs_ $vg/$lv1
#check_mirror_count_ $vg/$lv1 2
#mimages_are_redundant_ $vg $lv1
#mirrorlog_is_on_ $vg/$lv1 $dev3
#check_and_cleanup_lvs_
prepare_lvs_
lvcreate -l2 -m1 -n $lv1 $vg $dev1 $dev2 $dev3:0-1
check_mirror_count_ $vg/$lv1 2
check_mirror_log_ $vg/$lv1
lvconvert -m+1 -b $vg/$lv1 $dev4
lvconvert -m-1 $vg/$lv1 $dev2
lvconvert -i1 $vg/$lv1
wait_conversion_ $vg/$lv1
check_no_tmplvs_ $vg/$lv1
check_mirror_count_ $vg/$lv1 2
mimages_are_redundant_ $vg $lv1
mirrorlog_is_on_ $vg/$lv1 $dev3
check_and_cleanup_lvs_
# ---------------------------------------------------------------------

10
tools/lvchange.c
View File

@ -106,8 +106,6 @@ static int lvchange_availability(struct cmd_context *cmd,
{
int activate;
const char *pvname;
char *lv_full_name;
uint32_t len;
activate = arg_uint_value(cmd, available_ARG, 0);
@ -152,15 +150,9 @@ static int lvchange_availability(struct cmd_context *cmd,
}
if (lv->status & CONVERTING) {
len = strlen(lv->vg->name) + strlen(lv->name) + 2;
if (!(lv_full_name = alloca(len)))
return_0;
if (!dm_snprintf(lv_full_name, len, "%s/%s",
lv->vg->name, lv->name))
return_0;
log_verbose("Spawning background lvconvert process for %s",
lv->name);
lvconvert_poll(cmd, lv_full_name, 1);
lvconvert_poll(cmd, lv, 1);
}
}

37
tools/lvconvert.c
View File

@ -234,14 +234,16 @@ static int _read_params(struct lvconvert_params *lp, struct cmd_context *cmd,
return 1;
}
static struct volume_group *_get_lvconvert_vg(struct cmd_context *cmd,
const char *lv_name)
const char *lv_name, const char *uuid)
{
dev_close_all();
/*
* uuid is here LV uuid, but vg_read will use only first part.
*/
return vg_lock_and_read(cmd, extract_vgname(cmd, lv_name),
NULL, LCK_VG_WRITE,
uuid, LCK_VG_WRITE,
CLUSTERED | EXPORTED_VG | LVM_WRITE,
CORRECT_INCONSISTENT | FAIL_INCONSISTENT);
}
@ -249,9 +251,15 @@ static struct volume_group *_get_lvconvert_vg(struct cmd_context *cmd,
static struct logical_volume *_get_lvconvert_lv(struct cmd_context *cmd __attribute((unused)),
struct volume_group *vg,
const char *name,
const char *uuid,
uint32_t lv_type __attribute((unused)))
{
return find_lv(vg, name);
struct logical_volume *lv = find_lv(vg, name);
if (!lv || (uuid && strcmp(uuid, (char *)&lv->lvid)))
return NULL;
return lv;
}
static int _update_lvconvert_mirror(struct cmd_context *cmd __attribute((unused)),
@ -315,11 +323,24 @@ static struct poll_functions _lvconvert_mirror_fns = {
.finish_copy = _finish_lvconvert_mirror,
};
int lvconvert_poll(struct cmd_context *cmd, const char *lv_name,
int lvconvert_poll(struct cmd_context *cmd, struct logical_volume *lv,
unsigned background)
{
return poll_daemon(cmd, lv_name, background, 0, &_lvconvert_mirror_fns,
"Converted");
int len = strlen(lv->vg->name) + strlen(lv->name) + 2;
char *uuid = alloca(sizeof(lv->lvid));
char *lv_full_name = alloca(len);
if (!uuid || !lv_full_name)
return_0;
if (!dm_snprintf(lv_full_name, len, "%s/%s", lv->vg->name, lv->name))
return_0;
memcpy(uuid, &lv->lvid, sizeof(lv->lvid));
return poll_daemon(cmd, lv_full_name, uuid, background, 0,
&_lvconvert_mirror_fns, "Converted");
}
static int _insert_lvconvert_layer(struct cmd_context *cmd,
@ -883,7 +904,7 @@ bad:
log_print("Conversion starts after activation");
goto out;
}
ret = lvconvert_poll(cmd, lp.lv_name_full,
ret = lvconvert_poll(cmd, lvl->lv,
lp.wait_completion ? 0 : 1U);
}
out:

11
tools/polldaemon.c
View File

@ -129,7 +129,7 @@ static int _check_mirror_status(struct cmd_context *cmd,
return 1;
}
static int _wait_for_single_mirror(struct cmd_context *cmd, const char *name,
static int _wait_for_single_mirror(struct cmd_context *cmd, const char *name, const char *uuid,
struct daemon_parms *parms)
{
struct volume_group *vg;
@ -147,13 +147,13 @@ static int _wait_for_single_mirror(struct cmd_context *cmd, const char *name,
}
/* Locks the (possibly renamed) VG again */
if (!(vg = parms->poll_fns->get_copy_vg(cmd, name))) {
if (!(vg = parms->poll_fns->get_copy_vg(cmd, name, uuid))) {
log_error("ABORTING: Can't reread VG for %s", name);
/* What more could we do here? */
return 0;
}
if (!(lv_mirr = parms->poll_fns->get_copy_lv(cmd, vg, name,
if (!(lv_mirr = parms->poll_fns->get_copy_lv(cmd, vg, name, uuid,
parms->lv_type))) {
log_error("ABORTING: Can't find mirror LV in %s for %s",
vg->name, name);
@ -225,7 +225,8 @@ static void _poll_for_all_vgs(struct cmd_context *cmd,
}
}
int poll_daemon(struct cmd_context *cmd, const char *name, unsigned background,
int poll_daemon(struct cmd_context *cmd, const char *name, const char *uuid,
unsigned background,
uint32_t lv_type, struct poll_functions *poll_fns,
const char *progress_title)
{
@ -260,7 +261,7 @@ int poll_daemon(struct cmd_context *cmd, const char *name, unsigned background,
}
if (name) {
if (!_wait_for_single_mirror(cmd, name, &parms))
if (!_wait_for_single_mirror(cmd, name, uuid, &parms))
return ECMD_FAILED;
} else
_poll_for_all_vgs(cmd, &parms);

7
tools/polldaemon.h
View File

@ -21,10 +21,12 @@
struct poll_functions {
const char *(*get_copy_name_from_lv) (struct logical_volume *lv_mirr);
struct volume_group *(*get_copy_vg) (struct cmd_context *cmd,
const char *name);
const char *name,
const char *uuid);
struct logical_volume *(*get_copy_lv) (struct cmd_context *cmd,
struct volume_group *vg,
const char *name,
const char *uuid,
uint32_t lv_type);
int (*update_metadata) (struct cmd_context *cmd,
struct volume_group *vg,
@ -47,7 +49,8 @@ struct daemon_parms {
struct poll_functions *poll_fns;
};
int poll_daemon(struct cmd_context *cmd, const char *name, unsigned background,
int poll_daemon(struct cmd_context *cmd, const char *name, const char *uuid,
unsigned background,
uint32_t lv_type, struct poll_functions *poll_fns,
const char *progress_title);

4
tools/pvmove.c
View File

@ -551,7 +551,7 @@ static int _finish_pvmove(struct cmd_context *cmd, struct volume_group *vg,
}
static struct volume_group *_get_move_vg(struct cmd_context *cmd,
const char *name)
const char *name, const char *uuid)
{
struct physical_volume *pv;
@ -576,7 +576,7 @@ static struct poll_functions _pvmove_fns = {
int pvmove_poll(struct cmd_context *cmd, const char *pv_name,
unsigned background)
{
return poll_daemon(cmd, pv_name, background, PVMOVE, &_pvmove_fns,
return poll_daemon(cmd, pv_name, NULL, background, PVMOVE, &_pvmove_fns,
"Moved");
}

2
tools/tools.h
View File

@ -168,6 +168,6 @@ int arg_count_increment(struct cmd_context *cmd, int a);
const char *command_name(struct cmd_context *cmd);
int pvmove_poll(struct cmd_context *cmd, const char *pv, unsigned background);
int lvconvert_poll(struct cmd_context *cmd, const char *lv_name, unsigned background);
int lvconvert_poll(struct cmd_context *cmd, struct logical_volume *lv, unsigned background);
#endif