shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-17 06:04:23 +03:00
Code Releases Activity

Log failure type and recognise type 'F' (flush) in dmeventd mirror plugin.

Browse Source
This commit is contained in:
Alasdair Kergon 2009-11-25 15:59:07 +00:00
parent a2552d4f59
commit 32780caae3
2 changed files with 41 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
WHATS_NEW
View File

@ -1,6 +1,7 @@
Version 2.02.57 - Version 2.02.57 -
==================================== ====================================
Switch status from 32-bit to 64-bit. Log failure type and recognise type 'F' (flush) in dmeventd mirror plugin.
Extend internal PV/VG/LV/segment status variables from 32-bit to 64-bit.
Version 2.02.56 - 24th November 2009 Version 2.02.56 - 24th November 2009
==================================== ====================================

49
daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2005 Red Hat, Inc. All rights reserved. * Copyright (C) 2005-2009 Red Hat, Inc. All rights reserved.
* *
* This file is part of LVM2. * This file is part of LVM2.
* *
@ -27,6 +27,8 @@
#include <syslog.h> /* FIXME Replace syslog with multilog */ #include <syslog.h> /* FIXME Replace syslog with multilog */
/* FIXME Missing openlog? */ /* FIXME Missing openlog? */
/* FIXME Replace most syslogs with log_error() style messages and add complete context. */
/* FIXME Reformat to 80 char lines. */
#define ME_IGNORE 0 #define ME_IGNORE 0
#define ME_INSYNC 1 #define ME_INSYNC 1
@ -51,6 +53,36 @@ static void *_lvm_handle = NULL;
*/ */
static pthread_mutex_t _event_mutex = PTHREAD_MUTEX_INITIALIZER; static pthread_mutex_t _event_mutex = PTHREAD_MUTEX_INITIALIZER;
static int _process_status_code(const char status_code, const char *dev_name,
const char *dev_type, int r)
{
/*
* A => Alive - No failures
* D => Dead - A write failure occurred leaving mirror out-of-sync
* F => Flush failed.
* S => Sync - A sychronization failure occurred, mirror out-of-sync
* R => Read - A read failure occurred, mirror data unaffected
* U => Unclassified failure (bug)
*/
if (status_code == 'F') {
syslog(LOG_ERR, "%s device %s flush failed.\n",
dev_type, dev_name);
r = ME_FAILURE;
} else if (status_code == 'S')
syslog(LOG_ERR, "%s device %s sync failed.\n",
dev_type, dev_name);
else if (status_code == 'R')
syslog(LOG_ERR, "%s device %s read failed.\n",
dev_type, dev_name);
else if (status_code != 'A') {
syslog(LOG_ERR, "%s device %s has failed (%c).\n",
dev_type, dev_name, status_code);
r = ME_FAILURE;
}
return r;
}
static int _get_mirror_event(char *params) static int _get_mirror_event(char *params)
{ {
int i, r = ME_INSYNC; int i, r = ME_INSYNC;
@ -90,17 +122,14 @@ static int _get_mirror_event(char *params)
/* Check for bad mirror devices */ /* Check for bad mirror devices */
for (i = 0; i < num_devs; i++) for (i = 0; i < num_devs; i++)
if (dev_status_str[i] == 'D') { r = _process_status_code(dev_status_str[i], args[i],
syslog(LOG_ERR, "Mirror device, %s, has failed.\n", args[i]); i ? "Secondary mirror" : "Primary mirror", r);
r = ME_FAILURE;
}
/* Check for bad disk log device */ /* Check for bad disk log device */
if (log_argc > 1 && log_status_str[0] == 'D') { if (log_argc > 1)
syslog(LOG_ERR, "Log device, %s, has failed.\n", r = _process_status_code(log_status_str[0],
args[2 + num_devs + log_argc]); args[2 + num_devs + log_argc],
r = ME_FAILURE; "Log", r);
}
if (r == ME_FAILURE) if (r == ME_FAILURE)
goto out; goto out;