shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-22 06:50:52 +03:00
Code Releases Activity

lvmcache: free resource on error path

Browse Source 
Free allocated svg on error path.
Also explicitely ignore dm_strncpy() result.
(We know it will end with failure here.)
This commit is contained in:
Zdenek Kabelac 2019-11-08 12:51:48 +01:00
parent f90c3d69ce
commit 34bde8b6c7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/cache/lvmcache.c vendored
View File

@ -325,10 +325,12 @@ void lvmcache_save_vg(struct volume_group *vg, int precommitted)
dm_list_init(&svg->saved_vg_to_free);
dm_strncpy(svg->vgid, (const char *)vg->id.uuid, sizeof(svg->vgid));
/* Ignore result code, size we intentionally short-cut & pad with 0 */
(void) dm_strncpy(svg->vgid, (const char *)vg->id.uuid, sizeof(svg->vgid));
if (!dm_hash_insert(_saved_vg_hash, svg->vgid, svg)) {
log_error("lvmcache: failed to insert saved_vg %s", svg->vgid);
dm_free(svg);
return;
}
} else {