shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

stats: fix error path when region is NULL

Browse Source 
We should not call _stats_cleanup_region_ids() when regions
are NULL.
Also add backtracing for  goto.
This commit is contained in:
Zdenek Kabelac 2018-12-21 20:12:40 +01:00
parent 0161ebe484
commit 3750b0cff5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libdm/libdm-stats.c
View File

@ -4869,24 +4869,24 @@ uint64_t *dm_stats_update_regions_from_fd(struct dm_stats *dms, int fd,
group_id, &count, &regroup);
if (!regions)
goto bad;
goto_out;
if (!dm_stats_list(dms, NULL))
goto bad;
goto_bad;
/* regroup if there are regions to group */
if (regroup && (*regions != DM_STATS_REGION_NOT_PRESENT))
if (!_stats_group_file_regions(dms, regions, count, alias))
goto bad;
goto_bad;
dm_free(bounds);
dm_free((char *) alias);
return regions;
bad:
_stats_cleanup_region_ids(dms, regions, count);
dm_free(bounds);
dm_free(regions);
out:
dm_free(regions);
dm_free(bounds);
dm_free((char *) alias);
return NULL;
}