shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

vdo: enhance vdo pool extension

Browse Source 
When user tries to extend vdo pool - he needs to go always
at least by 1 full VDO slab  (defined as  vdo_slab_size_mb).

To avoid all trouble around find 'workable' size - lvm2 automatically
increases the passed (or by --use-policies calculated) extension size
(and informs a user about sometimes possibly large increase as slab
size can go upto 32GiB)

With VDO users need to always 'think-big' anyway and expect such
operation to be in GiB domain range.
This commit is contained in:
Zdenek Kabelac 2020-09-22 23:25:58 +02:00
parent f38b7afd62
commit 3a3307c0d8
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.03.11 -
==================================
Lvextend of vdo pool volumes ensure at least 1 new VDO slab is added.
Use revert_lv() on reload error path after vg_revert().
Configure --with-integrity enabled.
Restore lost signal blocking while VG lock is held.

21
lib/metadata/lv_manip.c
View File

@ -5465,6 +5465,27 @@ static int _lvresize_adjust_extents(struct logical_volume *lv,
else
seg_size = lp->extents - existing_extents;
if (lv_is_vdo_pool_data(lv)) {
if (!(seg = get_only_segment_using_this_lv(lv)))
return_0;
/* Min growth is defined this way: max(1 slab, 128M + 128K (recovery journal + slab summary)) */
new_extents = max(seg->vdo_params.slab_size_mb * 1024, UINT32_C(128 * 1024 + 128));
new_extents *= (1024 >> SECTOR_SHIFT); /* minimal growth (~128MiB..32GiB) in sectors */
if (new_extents > vg->extent_size) {
/* Minimal growth in extent size units */
new_extents = (new_extents + vg->extent_size - 1) / vg->extent_size;
if (new_extents > seg_size) {
/* Notify user about extra increase of extension */
log_print_unless_silent("Increasing incremention size from %s to %s to fit new VDO slab.",
display_size(cmd, (uint64_t)seg_size * vg->extent_size),
display_size(cmd, (uint64_t)new_extents * vg->extent_size));
seg_size = new_extents;
}
}
}
/* Convert PEs to LEs */
if (lp->extents_are_pes && !seg_is_striped(seg_last) && !seg_is_virtual(seg_last)) {
area_multiple = _calc_area_multiple(seg_last->segtype, seg_last->area_count, 0);