From 3c9177fdc0b8f94c0ae335790a485477901b685d Mon Sep 17 00:00:00 2001 From: Heinz Mauelshagen Date: Mon, 20 Jul 2020 15:36:25 +0200 Subject: [PATCH] lvconvert: display warning if raid1 LV image count does not change Fix "lvconvert -mN $RaidLV" to display a warning in case the same number of images is being requested. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1774696 --- lib/metadata/raid_manip.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c index 3b3e1d373..1ff2a0c85 100644 --- a/lib/metadata/raid_manip.c +++ b/lib/metadata/raid_manip.c @@ -3229,6 +3229,11 @@ int lv_raid_change_image_count(struct logical_volume *lv, int yes, uint32_t new_ const char *level = seg->area_count == 1 ? "raid1 with " : ""; const char *resil = new_count < seg->area_count ? "reducing" : "enhancing"; + if (new_count == seg->area_count) { + log_warn("Type %s LV %s already has %u images.", lvseg_name(seg), display_lvname(lv), new_count); + return 1; + } + /* LV must be active to perform raid conversion operations */ if (!lv_is_active(lv)) { log_error("%s must be active to perform this operation.",