shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

manip: optimize lvs_using_lv

Browse Source 
Instead of checking all LVs in a VG - do just a direct copy of LVs
from the existing list ->segs_using_thin_lv.

TODO: maybe it could be better to expose seg_list to /tools...
This commit is contained in:
Zdenek Kabelac 2019-10-31 12:38:56 +01:00
parent c21440536d
commit 3d9fc7d6f3
1 changed files with 8 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/metadata/mirror.c
View File

@ -1323,10 +1323,8 @@ struct dm_list *lvs_using_lv(struct cmd_context *cmd, struct volume_group *vg,
struct logical_volume *lv) struct logical_volume *lv)
{ {
struct dm_list *lvs; struct dm_list *lvs;
struct logical_volume *lv1; struct lv_list *lvl;
struct lv_list *lvl, *lvl1; struct seg_list *sl;
struct lv_segment *seg;
uint32_t s;
if (!(lvs = dm_pool_alloc(cmd->mem, sizeof(*lvs)))) { if (!(lvs = dm_pool_alloc(cmd->mem, sizeof(*lvs)))) {
log_error("lvs list alloc failed."); log_error("lvs list alloc failed.");
@ -1335,29 +1333,14 @@ struct dm_list *lvs_using_lv(struct cmd_context *cmd, struct volume_group *vg,
dm_list_init(lvs); dm_list_init(lvs);
/* Loop through all LVs except the one supplied */ dm_list_iterate_items(sl, &lv->segs_using_this_lv) {
dm_list_iterate_items(lvl1, &vg->lvs) {
lv1 = lvl1->lv;
if (lv1 == lv)
continue;
/* Find whether any segment points at the supplied LV */ /* Find whether any segment points at the supplied LV */
dm_list_iterate_items(seg, &lv1->segments) { if (!(lvl = dm_pool_alloc(cmd->mem, sizeof(*lvl)))) {
for (s = 0; s < seg->area_count; s++) { log_error("lv_list alloc failed.");
if (seg_type(seg, s) != AREA_LV || return NULL;
seg_lv(seg, s) != lv)
continue;
if (!(lvl = dm_pool_alloc(cmd->mem, sizeof(*lvl)))) {
log_error("lv_list alloc failed.");
return NULL;
}
lvl->lv = lv1;
dm_list_add(lvs, &lvl->list);
goto next_lv;
}
} }
next_lv: lvl->lv = sl->seg->lv;
; dm_list_add(lvs, &lvl->list);
} }
return lvs; return lvs;