shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

cleanup: reindent and make obvious error path

Browse Source
This commit is contained in:
Zdenek Kabelac 2014-08-18 22:04:39 +02:00
parent 10e2370d2e
commit 3e4a21427b
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
lib/filters/filter-mpath.c
View File

@ -158,25 +158,21 @@ static int dev_is_mpath(struct dev_filter *f, struct device *dev)
return 0;
switch (dev_get_primary_dev(dt, dev, &primary_dev)) {
default:
case 0:
/* Error. */
log_error("Failed to get primary device for %d:%d.", major, minor);
return 0;
case 1:
/* The dev is already a primary dev. Just continue with the dev. */
if (!(name = get_sysfs_name(dev)))
return_0;
break;
case 2:
/* The dev is partition. */
part_name = dev_name(dev); /* name of original dev for log_debug msg */
if (!(name = get_sysfs_name_by_devt(sysfs_dir, primary_dev, parent_name, PATH_MAX)))
return_0;
log_debug_devs("%s: Device is a partition, using primary "
"device %s for mpath component detection",
part_name, name);
break;
case 2: /* The dev is partition. */
part_name = dev_name(dev); /* name of original dev for log_debug msg */
if (!(name = get_sysfs_name_by_devt(sysfs_dir, primary_dev, parent_name, sizeof(parent_name))))
return_0;
log_debug_devs("%s: Device is a partition, using primary "
"device %s for mpath component detection",
part_name, name);
break;
case 1: /* The dev is already a primary dev. Just continue with the dev. */
if (!(name = get_sysfs_name(dev)))
return_0;
break;
default: /* 0, error. */
log_error("Failed to get primary device for %d:%d.", major, minor);
return 0;
}
if (dm_snprintf(path, PATH_MAX, "%s/block/%s/holders", sysfs_dir, name) < 0) {