shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cov: handle better leak reports

Browse Source 
Rewrite code so the leaks are eliminated from Coverity.
This commit is contained in:
Zdenek Kabelac 2021-09-19 20:27:34 +02:00
parent 825e49a244
commit 3e7e9cc5e6
1 changed files with 22 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
tools/command.c
View File

@ -757,6 +757,9 @@ static void _set_opt_def(struct cmd_context *cmdtool, struct command *cmd, char
def->num = (uint64_t)atoi(name);
if (val_enum == conststr_VAL) {
#ifdef MAN_PAGE_GENERATOR
free((void*)def->str);
#endif
def->str = dm_pool_strdup(cmdtool->libmem, name);
if (!def->str) {
@ -1539,20 +1542,27 @@ int define_commands(struct cmd_context *cmdtool, const char *run_name)
*/
if (_is_desc_line(line_argv[0]) && !skip && cmd) {
char *desc = dm_pool_strdup(cmdtool->libmem, line_orig);
if (cmd->desc && desc) {
int newlen = strlen(cmd->desc) + strlen(desc) + 2;
if (cmd->desc) {
size_t newlen = strlen(cmd->desc) + strlen(line_orig) + 2;
char *newdesc = dm_pool_alloc(cmdtool->libmem, newlen);
if (newdesc) {
snprintf(newdesc, newlen, "%s %s", cmd->desc, desc);
cmd->desc = newdesc;
} else {
if (!newdesc) {
/* FIXME */
stack;
return 0;
}
} else
cmd->desc = desc;
snprintf(newdesc, newlen, "%s %s", cmd->desc, line_orig);
#ifdef MAN_PAGE_GENERATOR
free((void*)cmd->desc);
#endif
cmd->desc = newdesc;
} else if (!(cmd->desc = dm_pool_strdup(cmdtool->libmem, line_orig))) {
/* FIXME */
stack;
return 0;
}
continue;
}
@ -1572,6 +1582,9 @@ int define_commands(struct cmd_context *cmdtool, const char *run_name)
}
if (_is_id_line(line_argv[0]) && cmd) {
#ifdef MAN_PAGE_GENERATOR
free((void*)cmd->command_id);
#endif
cmd->command_id = dm_pool_strdup(cmdtool->libmem, line_argv[1]);
if (!cmd->command_id) {
@ -3674,8 +3687,6 @@ static int _print_man(char *name, char *des_file, int secondary)
printf(".P\n");
}
}
continue;
}
return 1;