shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-24 06:04:19 +03:00
Code Releases Activity

Add FIXMEs

Browse Source 
Processing loop needs some thinking
This commit is contained in:
Zdenek Kabelac 2012-03-04 15:58:31 +00:00
parent 301c011a92
commit 3fb6ddf3ce
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/toollib.c
View File

@ -119,6 +119,10 @@ int process_each_lv_in_vg(struct cmd_context *cmd,
process_all = 1;
}
/*
* FIXME: In case of remove it goes through deleted entries,
* but it works since entries are allocated from vg mem pool.
*/
dm_list_iterate_items(lvl, &vg->lvs) {
if (lvl->lv->status & SNAPSHOT)
continue;
@ -182,6 +186,10 @@ int process_each_lv_in_vg(struct cmd_context *cmd,
}
if (lvargs_supplied && lvargs_matched != dm_list_size(arg_lvnames)) {
/*
* FIXME: lvm supports removal of LV with all its dependencies
* this leads to miscalculation that depends on the order of args.
*/
log_error("One or more specified logical volume(s) not found.");
if (ret_max < ECMD_FAILED)
ret_max = ECMD_FAILED;