diff --git a/lib/activate/fs.c b/lib/activate/fs.c index 5f26f5f1d..e116512b5 100644 --- a/lib/activate/fs.c +++ b/lib/activate/fs.c @@ -14,6 +14,7 @@ #include #include #include +#include #include static int _mk_dir(struct volume_group *vg) @@ -58,13 +59,55 @@ static int _rm_dir(struct volume_group *vg) return 1; } +static void _rm_blks(const char *dir) +{ + const char *name; + char path[PATH_MAX]; + struct dirent *dirent; + struct stat buf; + DIR *d; + + if (!(d = opendir(dir))) { + log_sys_error("opendir", dir); + return; + } + + while ((dirent = readdir(d))) { + name = dirent->d_name; + + if (!strcmp(name, ".") || !strcmp(name, "..")) + continue; + + if (lvm_snprintf(path, sizeof(path), "%s/%s", dir, name) == -1) { + log_error("Couldn't create path for %s", name); + continue; + } + + if (!lstat(path, &buf)) { + if (!S_ISBLK(buf.st_mode)) + continue; + log_very_verbose("Removing %s", path); + if (unlink(path) < 0) + log_sys_error("unlink", path); + } + } +} + static int _mk_link(struct logical_volume *lv, const char *dev) { - char lv_path[PATH_MAX], link_path[PATH_MAX]; + char lv_path[PATH_MAX], link_path[PATH_MAX], lvm1_group_path[PATH_MAX]; + char vg_path[PATH_MAX]; struct stat buf; - if (lvm_snprintf(lv_path, sizeof(lv_path), "%s%s/%s", - lv->vg->cmd->dev_dir, lv->vg->name, lv->name) == -1) { + if (lvm_snprintf(vg_path, sizeof(vg_path), "%s%s", + lv->vg->cmd->dev_dir, lv->vg->name) == -1) { + log_error("Couldn't create path for volume group dir %s", + lv->vg->name); + return 0; + } + + if (lvm_snprintf(lv_path, sizeof(lv_path), "%s/%s", vg_path, + lv->name) == -1) { log_error("Couldn't create source pathname for " "logical volume link %s", lv->name); return 0; @@ -77,13 +120,38 @@ static int _mk_link(struct logical_volume *lv, const char *dev) return 0; } + if (lvm_snprintf(lvm1_group_path, sizeof(lvm1_group_path), "%s/group", + vg_path) == -1) { + log_error("Couldn't create pathname for LVM1 group file for %s", + lv->vg->name); + return 0; + } + + /* To reach this point, the VG must have been locked. + * As locking fails if the VG is active under LVM1, it's + * now safe to remove any LVM1 devices we find here + * (as well as any existing LVM2 symlink). */ + if (!lstat(lvm1_group_path, &buf)) { + if (!S_ISCHR(buf.st_mode)) { + log_error("Non-LVM1 character device found at %s", + lvm1_group_path); + } else { + _rm_blks(vg_path); + + log_very_verbose("Removing %s", lvm1_group_path); + if (unlink(lvm1_group_path) < 0) + log_sys_error("unlink", lvm1_group_path); + } + } + if (!lstat(lv_path, &buf)) { - if (!S_ISLNK(buf.st_mode)) { + if (!S_ISLNK(buf.st_mode) && !S_ISBLK(buf.st_mode)) { log_error("Symbolic link %s not created: file exists", link_path); return 0; } + log_very_verbose("Removing %s", lv_path); if (unlink(lv_path) < 0) { log_sys_error("unlink", lv_path); return 0; @@ -110,12 +178,12 @@ static int _rm_link(struct logical_volume *lv, const char *lv_name) return 0; } - log_very_verbose("Removing link %s", lv_path); if (lstat(lv_path, &buf) || !S_ISLNK(buf.st_mode)) { log_error("%s not symbolic link - not removing", lv_path); return 0; } + log_very_verbose("Removing link %s", lv_path); if (unlink(lv_path) < 0) { log_sys_error("unlink", lv_path); return 0;