shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

coverity: return non-null string with internal error

Browse Source 
While we return internal error we should not let tool crash on NULL
access, so return valid string for such case.
This commit is contained in:
Zdenek Kabelac 2016-04-21 20:53:22 +02:00
parent 447daa9179
commit 412f09ca33
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/metadata/cache_manip.c
View File

@ -41,19 +41,19 @@ int cache_mode_is_set(const struct lv_segment *seg)
const char *get_cache_mode_name(const struct lv_segment *seg)
{
if (seg->feature_flags & DM_CACHE_FEATURE_WRITEBACK)
return "writeback";
if (seg->feature_flags & DM_CACHE_FEATURE_WRITETHROUGH)
return "writethrough";
if (seg->feature_flags & DM_CACHE_FEATURE_PASSTHROUGH)
return "passthrough";
log_error(INTERNAL_ERROR "LV %s has uknown feature flags %" PRIu64 ".",
display_lvname(seg->lv), seg->feature_flags);
if (seg->feature_flags & DM_CACHE_FEATURE_WRITEBACK)
return "writeback";
return NULL;
if (!seg->feature_flags & DM_CACHE_FEATURE_WRITETHROUGH) {
log_error(INTERNAL_ERROR "LV %s has uknown feature flags %" PRIu64 ", "
"returning writethrough instead.",
display_lvname(seg->lv), seg->feature_flags);
}
return "writethrough";
}
int cache_set_mode(struct lv_segment *seg, const char *str)