1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00

The function that runs to compress a stacked mirror after

converting from 2-way to 3-way mirror (collapse_mirrored_lv)
was calling '_remove_mirror_images' with the 'remove_log'
parameter set.  When the code was put in to fix 599898 to
honor log parameters during conversion, this argument was
suddenly being honored.  Thus, when someone would convert from
a 2-way to 3-way mirror, the log would get removed.

'collapse_mirrored_lv' should not be calling '_remove_mirror_images'
with 'remove_log' set.
This commit is contained in:
Jonathan Earl Brassow 2010-06-23 13:57:26 +00:00
parent 7c15f34267
commit 42f7fd0590

View File

@ -1038,7 +1038,7 @@ int collapse_mirrored_lv(struct logical_volume *lv)
if (!_remove_mirror_images(mirror_seg->lv, if (!_remove_mirror_images(mirror_seg->lv,
mirror_seg->area_count - 1, mirror_seg->area_count - 1,
_no_removable_images, NULL, 1, 1, NULL)) { _no_removable_images, NULL, 0, 1, NULL)) {
log_error("Failed to release mirror images"); log_error("Failed to release mirror images");
return 0; return 0;
} }