shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lv: add common lv_metadata_lv fn for use in report and dup, use brackets for invisible devices

Browse Source 
The common lv_metadata_lv fn avoids code duplication and also
the reporting part now uses _lvname_disp and _uuid_disp to display
name and uuid respectively, including brackets for the name if the
dev is invisible.
This commit is contained in:
Peter Rajnoha 2016-01-12 11:23:56 +01:00
parent cdbf76b2f0
commit 42fcbc1fd4
3 changed files with 27 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/metadata/lv.c
View File

@ -431,21 +431,27 @@ char *lv_data_lv_uuid_dup(struct dm_pool *mem, const struct logical_volume *lv)
return _do_lv_data_lv_dup(mem, lv, 1); return _do_lv_data_lv_dup(mem, lv, 1);
} }
struct logical_volume *lv_metadata_lv(const struct logical_volume *lv)
{
struct lv_segment *seg = (lv_is_thin_pool(lv) || lv_is_cache_pool(lv)) ?
first_seg(lv) : NULL;
struct logical_volume *metadata_lv = seg ? seg->metadata_lv : NULL;
return metadata_lv;
}
static char *_do_lv_metadata_lv_dup(struct dm_pool *mem, const struct logical_volume *lv, static char *_do_lv_metadata_lv_dup(struct dm_pool *mem, const struct logical_volume *lv,
int uuid) int uuid)
{ {
struct lv_segment *seg = (lv_is_thin_pool(lv) || lv_is_cache_pool(lv)) ? struct logical_volume *metadata_lv = lv_metadata_lv(lv);
first_seg(lv) : NULL;
if (seg) { if (!metadata_lv)
if (uuid) return NULL;
return lv_uuid_dup(mem, seg->metadata_lv);
else
return lv_name_dup(mem, seg->metadata_lv);
}
return NULL; if (uuid)
return lv_uuid_dup(mem, metadata_lv);
else
return lv_name_dup(mem, metadata_lv);
} }
char *lv_metadata_lv_dup(struct dm_pool *mem, const struct logical_volume *lv) char *lv_metadata_lv_dup(struct dm_pool *mem, const struct logical_volume *lv)

5
lib/metadata/lv.h
View File

@ -90,6 +90,11 @@ struct logical_volume *lv_convert_lv(const struct logical_volume *lv);
struct logical_volume *lv_origin_lv(const struct logical_volume *lv); struct logical_volume *lv_origin_lv(const struct logical_volume *lv);
struct logical_volume *lv_mirror_log_lv(const struct logical_volume *lv); struct logical_volume *lv_mirror_log_lv(const struct logical_volume *lv);
struct logical_volume *lv_data_lv(const struct logical_volume *lv); struct logical_volume *lv_data_lv(const struct logical_volume *lv);
struct logical_volume *lv_convert(const struct logical_volume *lv);
struct logical_volume *lv_origin(const struct logical_volume *lv);
struct logical_volume *lv_mirror_log(const struct logical_volume *lv);
struct logical_volume *lv_data(const struct logical_volume *lv);
struct logical_volume *lv_metadata_lv(const struct logical_volume *lv);
char *lv_parent_dup(struct dm_pool *mem, const struct logical_volume *lv); char *lv_parent_dup(struct dm_pool *mem, const struct logical_volume *lv);
char *lv_origin_dup(struct dm_pool *mem, const struct logical_volume *lv); char *lv_origin_dup(struct dm_pool *mem, const struct logical_volume *lv);
char *lv_origin_uuid_dup(struct dm_pool *mem, const struct logical_volume *lv); char *lv_origin_uuid_dup(struct dm_pool *mem, const struct logical_volume *lv);

15
lib/report/report.c
View File

@ -1701,16 +1701,15 @@ static int _do_metadatalv_disp(struct dm_report *rh, struct dm_pool *mem __attri
int uuid) int uuid)
{ {
const struct logical_volume *lv = (const struct logical_volume *) data; const struct logical_volume *lv = (const struct logical_volume *) data;
const struct lv_segment *seg = (lv_is_pool(lv)) ? first_seg(lv) : NULL; struct logical_volume *metadata_lv = lv_metadata_lv(lv);
if (seg) { if (!metadata_lv)
if (uuid) return _field_set_value(field, "", NULL);
return _uuid_disp(rh, mem, field, &seg->metadata_lv->lvid.id[1], private);
else
return _lvname_disp(rh, mem, field, seg->metadata_lv, private);
}
return _field_set_value(field, "", NULL); if (uuid)
return _uuid_disp(rh, mem, field, &metadata_lv->lvid.id[1], private);
else
return _lvname_disp(rh, mem, field, metadata_lv, private);
} }
static int _metadatalv_disp(struct dm_report *rh, struct dm_pool *mem __attribute__((unused)), static int _metadatalv_disp(struct dm_report *rh, struct dm_pool *mem __attribute__((unused)),