shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

bcache: add some error messages for debugging

Browse Source
This commit is contained in:
David Teigland 2018-02-27 12:37:25 -06:00
parent 21057676a1
commit 4331182964
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/device/bcache.c
View File

@ -659,8 +659,11 @@ static struct block *_new_block(struct bcache *cache, int fd, block_address inde
if (dm_list_empty(&cache->io_pending)) if (dm_list_empty(&cache->io_pending))
_writeback(cache, 16); // FIXME: magic number _writeback(cache, 16); // FIXME: magic number
_wait_io(cache); _wait_io(cache);
} else } else {
log_error("bcache no new blocks for fd %d index %u",
fd, (uint32_t)index);
return NULL; return NULL;
}
} }
} }
@ -676,6 +679,18 @@ static struct block *_new_block(struct bcache *cache, int fd, block_address inde
_hash_insert(b); _hash_insert(b);
} }
if (!b) {
log_error("bcache no new blocks for fd %d index %u "
"clean %u free %u dirty %u pending %u nr_data_blocks %u nr_cache_blocks %u",
fd, (uint32_t)index,
dm_list_size(&cache->clean),
dm_list_size(&cache->free),
dm_list_size(&cache->dirty),
dm_list_size(&cache->io_pending),
(uint32_t)cache->nr_data_blocks,
(uint32_t)cache->nr_cache_blocks);
}
return b; return b;
} }
@ -893,7 +908,7 @@ bool bcache_get(struct bcache *cache, int fd, block_address index,
} }
*result = NULL; *result = NULL;
log_warn("couldn't get block"); log_error("bcache failed to get block %u fd %d", (uint32_t)index, fd);
return false; return false;
} }
@ -1077,6 +1092,8 @@ bool bcache_write_bytes(struct bcache *cache, int fd, off_t start, size_t len, v
for (i = bb; i < be; i++) { for (i = bb; i < be; i++) {
if (!bcache_get(cache, fd, i, 0, &b)) { if (!bcache_get(cache, fd, i, 0, &b)) {
log_error("bcache_write failed to get block %u fd %d bb %u be %u",
(uint32_t)i, fd, (uint32_t)bb, (uint32_t)be);
errors++; errors++;
break; break;
} }