shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

Add checks for duplicate LV name, lvid and PV id before writing metadata.

Browse Source 
Report all sanity check failures, not just the first.
This commit is contained in:
Alasdair Kergon 2006-08-09 19:33:25 +00:00
parent 433b160fad
commit 438abca889
2 changed files with 51 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
WHATS_NEW
View File

@ -1,5 +1,7 @@
Version 2.02.08 - Version 2.02.08 -
================================ ================================
Add checks for duplicate LV name, lvid and PV id before writing metadata.
Report all sanity check failures, not just the first.
Fix missing lockfs on first snapshot creation. Fix missing lockfs on first snapshot creation.
Add unreliable --trustcache option to reporting commands. Add unreliable --trustcache option to reporting commands.
Fix locking for mimage removal. Fix locking for mimage removal.

53
lib/metadata/metadata.c
View File

@ -722,23 +722,68 @@ int vg_remove(struct volume_group *vg)
int vg_validate(struct volume_group *vg) int vg_validate(struct volume_group *vg)
{ {
struct lv_list *lvl; struct pv_list *pvl, *pvl2;
struct lv_list *lvl, *lvl2;
char uuid[64];
int r = 1;
list_iterate_items(pvl, &vg->pvs) {
list_iterate_items(pvl2, &vg->pvs) {
if (pvl == pvl2)
break;
if (id_equal(&pvl->pv->id,
&pvl2->pv->id)) {
if (!id_write_format(&pvl->pv->id, uuid,
sizeof(uuid)))
stack;
log_error("Internal error: Duplicate PV id "
"%s detected for %s in %s.",
uuid, dev_name(pvl->pv->dev),
vg->name);
r = 0;
}
}
}
if (!check_pv_segments(vg)) { if (!check_pv_segments(vg)) {
log_error("Internal error: PV segments corrupted in %s.", log_error("Internal error: PV segments corrupted in %s.",
vg->name); vg->name);
return 0; r = 0;
}
list_iterate_items(lvl, &vg->lvs) {
list_iterate_items(lvl2, &vg->lvs) {
if (lvl == lvl2)
break;
if (!strcmp(lvl->lv->name, lvl2->lv->name)) {
log_error("Internal error: Duplicate LV name "
"%s detected in %s.", lvl->lv->name,
vg->name);
r = 0;
}
if (id_equal(&lvl->lv->lvid.id[1],
&lvl2->lv->lvid.id[1])) {
if (!id_write_format(&lvl->lv->lvid.id[1], uuid,
sizeof(uuid)))
stack;
log_error("Internal error: Duplicate LV id "
"%s detected for %s and %s in %s.",
uuid, lvl->lv->name, lvl2->lv->name,
vg->name);
r = 0;
}
}
} }
list_iterate_items(lvl, &vg->lvs) { list_iterate_items(lvl, &vg->lvs) {
if (!check_lv_segments(lvl->lv, 1)) { if (!check_lv_segments(lvl->lv, 1)) {
log_error("Internal error: LV segments corrupted in %s.", log_error("Internal error: LV segments corrupted in %s.",
lvl->lv->name); lvl->lv->name);
return 0; r = 0;
} }
} }
return 1; return r;
} }
/* /*