shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00
Code Releases Activity

revert: commit 82d83a01ce

Browse Source 
The commit 82d83a01ce
"autoactivation: refresh existing VG before autoactivation"
causes problems (dangling udev_sync cookies, slow processing
of the pvscan --cache --major --minor call from udev rules)
when the autoactivation handler is run in parallel on
several PVs that belong to the same VG. Revert this patch
until the exact source of the problem is found and then
properly fixed and handled.
This commit is contained in:
Peter Rajnoha 2013-09-02 13:46:49 +02:00
parent 039585bb0d
commit 44c1a02c18
2 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -14,7 +14,6 @@ Version 2.02.101 -
Prevent cluster mirror logs from being corrupted by redundant checkpoints. Prevent cluster mirror logs from being corrupted by redundant checkpoints.
Fix ignored lvmetad update on loop device configuration (2.02.99). Fix ignored lvmetad update on loop device configuration (2.02.99).
Use LVM_PATH instead of hardcoded value in lvm2 activation systemd generator. Use LVM_PATH instead of hardcoded value in lvm2 activation systemd generator.
Refresh existing VG before autoactivation (event retrigger/device reappeared).
Fix vgck to notice on-disk corruption even if lvmetad is used. Fix vgck to notice on-disk corruption even if lvmetad is used.
Move mpath device filter before partitioned filter (which opens devices). Move mpath device filter before partitioned filter (which opens devices).
Split partitioned filter out of lvm_type filter. Split partitioned filter out of lvm_type filter.

20
tools/pvscan.c
View File

@ -98,7 +98,6 @@ static int _auto_activation_handler(struct cmd_context *cmd,
struct volume_group *vg; struct volume_group *vg;
int consistent = 0; int consistent = 0;
struct id vgid_raw; struct id vgid_raw;
int r = 0;
/* TODO: add support for partial and clustered VGs */ /* TODO: add support for partial and clustered VGs */
if (partial) if (partial)
@ -107,29 +106,24 @@ static int _auto_activation_handler(struct cmd_context *cmd,
if (!id_read_format(&vgid_raw, vgid)) if (!id_read_format(&vgid_raw, vgid))
return_0; return_0;
/* NB. This is safe because we know lvmetad is running and we won't hit disk. */ /* NB. This is safe because we know lvmetad is running and we won't hit
* disk. */
if (!(vg = vg_read_internal(cmd, NULL, (const char *) &vgid_raw, 0, &consistent))) if (!(vg = vg_read_internal(cmd, NULL, (const char *) &vgid_raw, 0, &consistent)))
return 1; return 1;
if (vg_is_clustered(vg)) { if (vg_is_clustered(vg)) {
r = 1; goto out; release_vg(vg);
} return 1;
if (!vg_refresh_visible(vg->cmd, vg)) {
log_error("%s: refresh before autoactivation failed.", vg->name);
goto out;
} }
if (!vgchange_activate(vg->cmd, vg, activate)) { if (!vgchange_activate(vg->cmd, vg, activate)) {
log_error("%s: autoactivation failed.", vg->name); log_error("%s: autoactivation failed.", vg->name);
goto out; release_vg(vg);
return 0;
} }
r = 1;
out:
release_vg(vg); release_vg(vg);
return r; return 1;
} }
static int _pvscan_lvmetad(struct cmd_context *cmd, int argc, char **argv) static int _pvscan_lvmetad(struct cmd_context *cmd, int argc, char **argv)