mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-02 22:42:30 +03:00
vdo: suffle code for better error path handling
For failing dm_ no need to report 2nd. error, but we missed to report error with 'updated==NULL'.
This commit is contained in:
parent
e2e31d9acf
commit
493acb9195
@ -1347,23 +1347,23 @@ int get_vdo_settings(struct cmd_context *cmd,
|
||||
u |= VDO_CHANGE_ONLINE;
|
||||
}
|
||||
|
||||
if (updated) {
|
||||
// validation of updated VDO option
|
||||
if (!dm_vdo_validate_target_params(vtp, 0 /* vdo_size */)) {
|
||||
err:
|
||||
if (is_lvchange)
|
||||
log_error("Cannot change VDO setting \"vdo_%s\" in existing VDO pool.",
|
||||
option);
|
||||
else
|
||||
log_error("Invalid argument for VDO setting \"vdo_%s\".",
|
||||
option);
|
||||
goto out;
|
||||
}
|
||||
// validation of updated VDO option
|
||||
if (!dm_vdo_validate_target_params(vtp, 0 /* vdo_size */))
|
||||
goto_out;
|
||||
|
||||
if (updated)
|
||||
*updated = u;
|
||||
}
|
||||
|
||||
r = 1;
|
||||
r = 1; // success
|
||||
goto out;
|
||||
err:
|
||||
if (is_lvchange)
|
||||
log_error("Cannot change VDO setting \"vdo_%s\" in existing VDO pool.",
|
||||
option);
|
||||
else
|
||||
log_error("Invalid argument for VDO setting \"vdo_%s\".",
|
||||
option);
|
||||
|
||||
out:
|
||||
if (result)
|
||||
dm_config_destroy(result);
|
||||
|
Loading…
Reference in New Issue
Block a user