shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

vdo: suffle code for better error path handling

Browse Source 
For failing dm_ no need to report 2nd. error,
but we missed to report error with 'updated==NULL'.
This commit is contained in:
Zdenek Kabelac 2022-07-09 21:33:57 +02:00
parent e2e31d9acf
commit 493acb9195
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tools/toollib.c
View File

@ -1347,23 +1347,23 @@ int get_vdo_settings(struct cmd_context *cmd,
u |= VDO_CHANGE_ONLINE; u |= VDO_CHANGE_ONLINE;
} }
if (updated) { // validation of updated VDO option
// validation of updated VDO option if (!dm_vdo_validate_target_params(vtp, 0 /* vdo_size */))
if (!dm_vdo_validate_target_params(vtp, 0 /* vdo_size */)) { goto_out;
err:
if (is_lvchange)
log_error("Cannot change VDO setting \"vdo_%s\" in existing VDO pool.",
option);
else
log_error("Invalid argument for VDO setting \"vdo_%s\".",
option);
goto out;
}
if (updated)
*updated = u; *updated = u;
}
r = 1; r = 1; // success
goto out;
err:
if (is_lvchange)
log_error("Cannot change VDO setting \"vdo_%s\" in existing VDO pool.",
option);
else
log_error("Invalid argument for VDO setting \"vdo_%s\".",
option);
out: out:
if (result) if (result)
dm_config_destroy(result); dm_config_destroy(result);