shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

tests: nomda-restoremissing

Browse Source 
This test was broken by commit 69ea2e3f9
"vg_read: keep MISSING_PV when device with no mda reappears"
Change the test to match the new behavior.
This commit is contained in:
David Teigland 2023-03-20 12:42:50 -05:00
parent ddfe839dd1
commit 49dbeb9b45
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/shell/nomda-restoremissing.sh
View File

@ -31,7 +31,18 @@ not vgck $vg 2>&1 | tee log
grep "missing 1 physical volume" log
not lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg # write operations fail
aux enable_dev "$dev1"
lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg # no MDA => automatically restored
# Old versions would automatically clear MISSING_PV on a PV that had no mda,
# but this made no sense; the existence of an mda means nothing for the
# validity of the data on the device. I suspect that at some point in the
# past, the MISSING_PV flag was used to decide if metadata could be used
# from the device, so the flag could be cleared on a PV with no mda.
# These days lvm knows when to ignore outdated metadata.
# MISSING_PV probably has little to no value for determining valid data either,
# so it's likely that we'll begin to automatically clear MISSING_PV in the
# future (but it will have nothing to do with having mdas.)
not lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg
vgextend --restoremissing $vg "$dev1"
lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg
vgck $vg
vgremove -ff $vg