shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

vgchange: disable cluster convert for active LVs

Browse Source 
While we could probably reacquire some type of lock when
going from non-clustered to clustered vg, we don't have any
single road back to drop the lock and keep LV active.

For now keep it safe and prohibit conversion when LV
is active in the VG.
This commit is contained in:
Zdenek Kabelac 2014-09-16 11:41:28 +02:00
parent 1ce21c19d5
commit 4a853361b0
3 changed files with 29 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.112 -
=====================================
Disable vgchange of clustered attribute with any active LV in VG.
Use va_copy to properly pass va_list through functions.
Add function to detect rotational devices.
Review internal checks for mirror/raid/pvmove volumes.

42
lib/metadata/vg.c
View File

@ -519,36 +519,24 @@ int vg_set_alloc_policy(struct volume_group *vg, alloc_policy_t alloc)
return 1;
}
/*
* We do not currently support switching the cluster attribute
* with any active logical volumes.
*
* FIXME: resolve logic with reacquiring proper top-level LV locks
* and we likely can't giveup DLM locks for active LVs...
*/
int vg_set_clustered(struct volume_group *vg, int clustered)
{
struct lv_list *lvl;
struct logical_volume *lv;
/*
* We do not currently support switching the cluster attribute
* on active mirrors, snapshots or RAID logical volumes.
*/
dm_list_iterate_items(lvl, &vg->lvs) {
if (lv_is_active(lvl->lv) &&
(lv_is_mirrored(lvl->lv) || lv_is_raid_type(lvl->lv))) {
log_error("%s logical volumes must be inactive "
"when changing the cluster attribute.",
lv_is_raid_type(lvl->lv) ? "RAID" : "Mirror");
return 0;
}
if (clustered) {
if (lv_is_origin(lvl->lv) || lv_is_cow(lvl->lv)) {
log_error("Volume group %s contains snapshots "
"that are not yet supported.",
vg->name);
return 0;
}
}
if ((lv_is_origin(lvl->lv) || lv_is_cow(lvl->lv)) &&
lv_is_active(lvl->lv)) {
log_error("Snapshot logical volumes must be inactive "
"when changing the cluster attribute.");
/* For COW, check lock for origin */
lv = lv_is_cow(lvl->lv) ? origin_from_cow(lvl->lv) : lvl->lv;
if (lv_is_active(lv)) {
log_error("Can't change cluster attribute with active "
"oogical volume %s.", display_lvname(lv));
return 0;
}
}
@ -557,6 +545,10 @@ int vg_set_clustered(struct volume_group *vg, int clustered)
vg->status |= CLUSTERED;
else
vg->status &= ~CLUSTERED;
log_debug_metadata("Setting volume group %s as %sclustered.",
vg->name, clustered ? "" : "not " );
return 1;
}

11
test/shell/vgchange-usage.sh
View File

@ -89,16 +89,27 @@ fail vgchange -cy |& tee out
grep "y/n" out
check vg_attr_bit cluster $vg "-"
lvcreate -l1 $vg
# check on cluster
# either skipped as clustered (non-cluster), or already clustered (on cluster)
if test -e LOCAL_CLVMD ; then
# can't switch with active LV
not vgchange -cy $vg
lvchange -an $vg
vgchange -cy $vg
fail vgchange -cy $vg
check vg_attr_bit cluster $vg "c"
lvchange -ay $vg
not vgchange -cn $vg
lvchange -an $vg
vgchange -cn $vg
else
# no clvmd is running
fail vgchange -cy $vg
# can't switch with active LV
not vgchange --yes -cy $vg
lvchange -an $vg
vgchange --yes -cy $vg
fail vgchange --yes -cy $vg
fail vgs $vg |& tee out