shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-28 20:25:52 +03:00
Code Releases Activity

lvmetad: remove unneeded FIXME

Browse Source 
This case is now handled correctly.
This commit is contained in:
David Teigland 2015-11-16 13:44:57 -06:00
parent 920a281994
commit 4a984cabc4
1 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
daemons/lvmetad/lvmetad-core.c
View File

@ -1542,23 +1542,11 @@ static int _update_metadata(lvmetad_state *s, const char *arg_name, const char *
}
if (strcmp(arg_vgid_lookup, arg_vgid)) {
/*
* This shouldn't usually happen, but could when
* disks are moved (or filters are changed?)
*
* FIXME: two different VGs with different uuids, on
* different PVs could have the same name, e.g. disks
* are moved, filters are changed. Possible solution:
* purge all info for these VGs and return an error
* that causes the command to go to disk. Would this
* only happen from pv_found?
* Until there's a proper solution, ignore this VG.
*/
ERROR(s, "update_metadata ignore VG with duplicate name %s vgid %s pvid %s existing vgid %s",
arg_name, arg_vgid, pvid ?: "none", arg_vgid_lookup);
unlock_vgid_to_metadata(s);
retval = 0;
goto out;
/* This shouldn't happen. Two VGs with the same name is handled above. */
ERROR(s, "update_metadata arg_vgid %s arg_name %s mismatch arg_vgid_lookup %s",
arg_vgid, arg_name, arg_vgid_lookup);
needs_repair = 1;
goto update;
}
/* old_vgid == arg_vgid, and old_name == arg_name */